phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-24 20:43:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: replace C-style casts with static_cast and extract toLowerInPlace

Browse source 
Replace ~300 C-style casts ((int), (float), (uint32_t), etc.) with
static_cast across 15 source files. Extract toLowerInPlace() helper in
lua_engine.cpp to replace 72 identical tolower loop patterns.
This commit is contained in:
Kelsi 2026-03-25 11:40:49 -07:00
parent d646a0451d
commit 05f2bedf88
15 changed files with 385 additions and 381 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/auth/auth_packets.cpp
View file

@ -207,7 +207,7 @@ bool LogonChallengeResponseParser::parse(network::Packet& packet, LogonChallenge
LOG_DEBUG(" g size: ", response.g.size(), " bytes");
LOG_DEBUG(" N size: ", response.N.size(), " bytes");
LOG_DEBUG(" salt size: ", response.salt.size(), " bytes");
LOG_DEBUG(" Security flags: ", (int)response.securityFlags);
LOG_DEBUG(" Security flags: ", static_cast<int>(response.securityFlags));
if (response.securityFlags & 0x01) {
LOG_DEBUG(" PIN grid seed: ", response.pinGridSeed);
}
@ -317,10 +317,10 @@ bool LogonProofResponseParser::parse(network::Packet& packet, LogonProofResponse
// Status
response.status = packet.readUInt8();
LOG_INFO("LOGON_PROOF response status: ", (int)response.status);
LOG_INFO("LOGON_PROOF response status: ", static_cast<int>(response.status));
if (response.status != 0) {
LOG_ERROR("LOGON_PROOF failed with status: ", (int)response.status);
LOG_ERROR("LOGON_PROOF failed with status: ", static_cast<int>(response.status));
return true; // Valid packet, but proof failed
}
@ -428,13 +428,13 @@ bool RealmListResponseParser::parse(network::Packet& packet, RealmListResponse&
LOG_DEBUG(" Realm ", static_cast<int>(i), " details:");
LOG_DEBUG(" Name: ", realm.name);
LOG_DEBUG(" Address: ", realm.address);
LOG_DEBUG(" ID: ", (int)realm.id);
LOG_DEBUG(" Icon: ", (int)realm.icon);
LOG_DEBUG(" Lock: ", (int)realm.lock);
LOG_DEBUG(" Flags: ", (int)realm.flags);
LOG_DEBUG(" ID: ", static_cast<int>(realm.id));
LOG_DEBUG(" Icon: ", static_cast<int>(realm.icon));
LOG_DEBUG(" Lock: ", static_cast<int>(realm.lock));
LOG_DEBUG(" Flags: ", static_cast<int>(realm.flags));
LOG_DEBUG(" Population: ", realm.population);
LOG_DEBUG(" Characters: ", (int)realm.characters);
LOG_DEBUG(" Timezone: ", (int)realm.timezone);
LOG_DEBUG(" Characters: ", static_cast<int>(realm.characters));
LOG_DEBUG(" Timezone: ", static_cast<int>(realm.timezone));
response.realms.push_back(realm);
}