phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-14 00:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: guild event string never appended; /leave left stale party state

Browse source 
1. Contradictory condition (!numStrings && numStrings >= 1) was always
   false, so unknown guild event messages never included the server's
   context string. Fixed to just numStrings >= 1.

2. leaveParty() only sent the packet without clearing partyData or
   firing addon events, so /leave left party frames visible until the
   server pushed an update. Now delegates to leaveGroup() which handles
   both the packet and local state cleanup.
This commit is contained in:
Kelsi 2026-03-29 19:31:21 -07:00
parent 3da3638790
commit 061a21da8f
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/game/social_handler.cpp
View file

@ -1144,10 +1144,11 @@ void SocialHandler::uninvitePlayer(const std::string& playerName) {
}
void SocialHandler::leaveParty() {
if (owner_.getState() != WorldState::IN_WORLD || !owner_.socket) return;
auto packet = GroupDisbandPacket::build();
owner_.socket->send(packet);
owner_.addSystemChatMessage("You have left the group.");
// Delegates to leaveGroup which handles both the packet send AND local
// state cleanup (clearing partyData, firing addon events). Previously
// this method only sent the packet, leaving the client thinking it was
// still in a group until the server pushed a group list update.
leaveGroup();
}
void SocialHandler::setMainTank(uint64_t targetGuid) {
@ -1500,7 +1501,8 @@ void SocialHandler::handleGuildEvent(network::Packet& packet) {
break;
default:
msg = "Guild event " + std::to_string(data.eventType);
if (!data.numStrings && data.numStrings >= 1) msg += ": " + data.strings[0];
// Was `!numStrings && numStrings >= 1` — always false (0 can't be ≥1).
if (data.numStrings >= 1) msg += ": " + data.strings[0];
break;
}