phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-07 09:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(npc): guard NpcSpawner::scatter against zero radius and bad inputs

Browse source 
A radius of 0 would either throw from the uniform distribution
constructor (uniform_real_distribution requires a < b) or divide
by zero in the sqrt-based area-uniform sampler. Also reject NaN
center, non-positive radius, and absurdly large counts (>10k)
which would freeze the editor on placement.
This commit is contained in:
Kelsi 2026-05-06 06:54:48 -07:00
parent d96d040831
commit 10e77f1c2e
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tools/editor/npc_spawner.cpp
View file

@ -109,6 +109,15 @@ bool NpcSpawner::saveToFile(const std::string& path) const {
void NpcSpawner::scatter(const CreatureSpawn& base, const glm::vec3& center,
float radius, int count) {
// Defensive bounds — UI sliders cap these, but the function is also
// callable programmatically. radius<=0 would either throw from the
// uniform distribution constructor or divide by zero on the sqrt
// line; an absurd count would freeze the editor and OOM.
if (count <= 0 || count > 10000) return;
if (!std::isfinite(radius) || radius <= 0.0f) return;
if (!std::isfinite(center.x) || !std::isfinite(center.y) ||
!std::isfinite(center.z)) return;
std::mt19937 rng(static_cast<uint32_t>(center.x * 100 + center.y * 37));
std::uniform_real_distribution<float> distAngle(0.0f, 6.2831853f);
std::uniform_real_distribution<float> distDist(0.0f, radius);