phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-07 09:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(viewport): hide path preview on zero-length input

Browse source 
start == end would call glm::normalize on a zero vector, producing
NaN dir/perp and NaN ribbon vertex positions. Vulkan would either
drop the draw silently or trip a validation error. Hide the preview
when the segment is degenerate.
This commit is contained in:
Kelsi 2026-05-06 07:53:07 -07:00
parent 4babaebf86
commit 130aa34d73
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/editor/editor_viewport.cpp
View file

@ -436,7 +436,13 @@ void EditorViewport::setPathPreview(const glm::vec3& start, const glm::vec3& end
struct BV { float pos[3]; float color[4]; };
std::vector<BV> verts;
glm::vec2 dir = glm::normalize(glm::vec2(end.x - start.x, end.y - start.y));
glm::vec2 delta(end.x - start.x, end.y - start.y);
float dlen = glm::length(delta);
// start == end would produce NaN dir/perp from glm::normalize and then
// NaN positions in the path ribbon — Vulkan would either drop the draw
// or crash on validation. Hide the preview instead.
if (dlen < 1e-4f) { pathVisible_ = false; return; }
glm::vec2 dir = delta / dlen;
glm::vec2 perp(-dir.y, dir.x);
float z0 = start.z + 2.0f;
float z1 = end.z + 2.0f;