From 16c8a2fd33ee664b9c7fbbcdfc3e29d7daa01cd8 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Fri, 13 Mar 2026 21:08:00 -0700 Subject: [PATCH] fix(combatlog): parse packed spell-go hit target GUIDs --- src/game/world_packets.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/game/world_packets.cpp b/src/game/world_packets.cpp index dbcbf4c9..b135fd6b 100644 --- a/src/game/world_packets.cpp +++ b/src/game/world_packets.cpp @@ -3660,12 +3660,13 @@ bool SpellGoParser::parse(network::Packet& packet, SpellGoData& data) { data.hitTargets.reserve(data.hitCount); for (uint8_t i = 0; i < data.hitCount; ++i) { - if (packet.getSize() - packet.getReadPos() < 8) { + // WotLK hit targets are packed GUIDs, like the caster and miss targets. + if (packet.getSize() - packet.getReadPos() < 1) { LOG_WARNING("Spell go: truncated hit targets at index ", (int)i, "/", (int)data.hitCount); data.hitCount = i; break; } - data.hitTargets.push_back(packet.readUInt64()); + data.hitTargets.push_back(UpdateObjectParser::readPackedGuid(packet)); } // Validate missCount field exists