phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-05 00:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: play minimap ping sound when party members ping the map

Browse source 
Add playMinimapPing() to UiSoundManager with MapPing.wav (falls back to
target select sound). Play the ping sound in MSG_MINIMAP_PING handler
when the sender is not the local player. Provides audio feedback for
party member map pings, matching WoW behavior.
This commit is contained in:
Kelsi 2026-03-20 18:21:34 -07:00
parent f03ed8551b
commit 180990b9f1
3 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/audio/ui_sound_manager.cpp
View file

@ -130,6 +130,12 @@ bool UiSoundManager::initialize(pipeline::AssetManager* assets) {
}
}
// Minimap ping sound
minimapPingSounds_.resize(1);
if (!loadSound("Sound\\Interface\\MapPing.wav", minimapPingSounds_[0], assets)) {
minimapPingSounds_ = selectTargetSounds_; // fallback to target select sound
}
LOG_INFO("UISoundManager: Window sounds - Bag: ", (bagOpenLoaded && bagCloseLoaded) ? "YES" : "NO",
", QuestLog: ", (questLogOpenLoaded && questLogCloseLoaded) ? "YES" : "NO",
", CharSheet: ", (charSheetOpenLoaded && charSheetCloseLoaded) ? "YES" : "NO");
@ -236,5 +242,8 @@ void UiSoundManager::playTargetDeselect() { playSound(deselectTargetSounds_); }
// Chat notifications
void UiSoundManager::playWhisperReceived() { playSound(whisperSounds_); }
// Minimap ping
void UiSoundManager::playMinimapPing() { playSound(minimapPingSounds_); }
} // namespace audio
} // namespace wowee

7
src/game/game_handler.cpp
View file

@ -3544,6 +3544,13 @@ void GameHandler::handlePacket(network::Packet& packet) {
ping.wowY = pingX; // canonical WoW Y = west = server's posX
ping.age = 0.0f;
minimapPings_.push_back(ping);
// Play ping sound for other players' pings (not our own)
if (senderGuid != playerGuid) {
if (auto* renderer = core::Application::getInstance().getRenderer()) {
if (auto* sfx = renderer->getUiSoundManager())
sfx->playMinimapPing();
}
}
break;
}
case Opcode::SMSG_ZONE_UNDER_ATTACK: {