phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-08 18:13:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

test(open-formats): add WOB doodad NaN scrub test

Browse source 
Verifies the recent WOB doodad-transform sanitize. A WOB with NaN
position/rotation/scale on a doodad should load with the doodad
zeroed out (position/rotation 0, scale 1). Prevents regressing
the GPU crash that NaN model matrices would cause.
This commit is contained in:
Kelsi 2026-05-06 07:21:20 -07:00
parent a16689f7fa
commit 19e479a8ff
1 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

42
tests/test_open_formats.cpp
View file

@ -8,6 +8,8 @@
#include <filesystem>
#include <fstream>
#include <cstring>
#include <limits>
#include <cmath>
using namespace wowee::pipeline;
@ -611,6 +613,46 @@ TEST_CASE("WOC rejects absurdly large triangle counts", "[woc][hardening]") {
std::filesystem::remove(path);
}
TEST_CASE("WOB scrubs NaN doodad transform on load", "[wob][hardening]") {
ensureTestDir();
std::string base = TEST_DIR + "/nan_doodad";
std::string path = base + ".wob";
{
std::ofstream f(path, std::ios::binary);
uint32_t magic = 0x31424F57; // "WOB1"
uint32_t gc = 0, pc = 0, dc = 1;
float boundRadius = 5.0f;
f.write(reinterpret_cast<const char*>(&magic), 4);
f.write(reinterpret_cast<const char*>(&gc), 4);
f.write(reinterpret_cast<const char*>(&pc), 4);
f.write(reinterpret_cast<const char*>(&dc), 4);
f.write(reinterpret_cast<const char*>(&boundRadius), 4);
// Empty name string
uint16_t nameLen = 0;
f.write(reinterpret_cast<const char*>(&nameLen), 2);
// Doodad with NaN position/rotation/scale
std::string mp = "Tree.wom";
uint16_t mpLen = static_cast<uint16_t>(mp.size());
f.write(reinterpret_cast<const char*>(&mpLen), 2);
f.write(mp.data(), mpLen);
float nan = std::numeric_limits<float>::quiet_NaN();
glm::vec3 nanv(nan, nan, nan);
f.write(reinterpret_cast<const char*>(&nanv), 12);
f.write(reinterpret_cast<const char*>(&nanv), 12);
f.write(reinterpret_cast<const char*>(&nan), 4);
}
auto bld = WoweeBuildingLoader::load(base);
// isValid requires a group — we deliberately wrote 0 groups to keep
// the test fixture small. Just check the doodad got loaded + scrubbed.
REQUIRE(bld.doodads.size() == 1);
REQUIRE(std::isfinite(bld.doodads[0].position.x));
REQUIRE(bld.doodads[0].position == glm::vec3(0, 0, 0));
REQUIRE(bld.doodads[0].rotation == glm::vec3(0, 0, 0));
REQUIRE(bld.doodads[0].scale == 1.0f);
std::filesystem::remove(path);
}
TEST_CASE("WOC clamps out-of-range tile coords on load", "[woc][hardening]") {
ensureTestDir();
std::string path = TEST_DIR + "/oor_tile_woc.woc";