phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 17:43:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: auto-acknowledge cinematic and movie triggers to prevent server hangs

Browse source 
Send CMSG_NEXT_CINEMATIC_CAMERA in response to SMSG_TRIGGER_CINEMATIC
and CMSG_COMPLETE_MOVIE in response to SMSG_TRIGGER_MOVIE. Some WotLK
servers block further packets or disconnect clients that don't respond
to these triggers, especially during the intro cinematic on first login.
This commit is contained in:
Kelsi 2026-03-20 04:53:54 -07:00
parent f4d705738b
commit 1ae4cfaf3f
1 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/game/game_handler.cpp
View file

@ -4554,11 +4554,16 @@ void GameHandler::handlePacket(network::Packet& packet) {
} }
break; break;
} }
case Opcode::SMSG_TRIGGER_CINEMATIC: case Opcode::SMSG_TRIGGER_CINEMATIC: {
// uint32 cinematicId — we don't play cinematics; consume and skip. // uint32 cinematicId — we don't play cinematics; acknowledge immediately.
packet.setReadPos(packet.getSize()); packet.setReadPos(packet.getSize());
LOG_DEBUG("SMSG_TRIGGER_CINEMATIC: skipped"); // Send CMSG_NEXT_CINEMATIC_CAMERA to signal cinematic completion;
// servers may block further packets until this is received.
network::Packet ack(wireOpcode(Opcode::CMSG_NEXT_CINEMATIC_CAMERA));
socket->send(ack);
LOG_DEBUG("SMSG_TRIGGER_CINEMATIC: skipped, sent CMSG_NEXT_CINEMATIC_CAMERA");
break; break;
}
case Opcode::SMSG_LOOT_MONEY_NOTIFY: { case Opcode::SMSG_LOOT_MONEY_NOTIFY: {
// Format: uint32 money + uint8 soleLooter // Format: uint32 money + uint8 soleLooter
@ -6298,9 +6303,19 @@ void GameHandler::handlePacket(network::Packet& packet) {
} }
// ---- Movie trigger ---- // ---- Movie trigger ----
case Opcode::SMSG_TRIGGER_MOVIE: case Opcode::SMSG_TRIGGER_MOVIE: {
// uint32 movieId — we don't play movies; acknowledge immediately.
packet.setReadPos(packet.getSize()); packet.setReadPos(packet.getSize());
// WotLK servers expect CMSG_COMPLETE_MOVIE after the movie finishes;
// without it, the server may hang or disconnect the client.
uint16_t wire = wireOpcode(Opcode::CMSG_COMPLETE_MOVIE);
if (wire != 0xFFFF) {
network::Packet ack(wire);
socket->send(ack);
LOG_DEBUG("SMSG_TRIGGER_MOVIE: skipped, sent CMSG_COMPLETE_MOVIE");
}
break; break;
}
// ---- Equipment sets ---- // ---- Equipment sets ----
case Opcode::SMSG_EQUIPMENT_SET_LIST: case Opcode::SMSG_EQUIPMENT_SET_LIST: