phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-06 21:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: wire SpellHandler::updateTimers and remove stale cast state members

Browse source 
SpellHandler::updateTimers() was never called after PR #23 extraction,
so cast bar timers, spell cooldowns, and unit cast state timers never
ticked. Also removes duplicate cast/queue/spell members left in
GameHandler that shadowed the SpellHandler versions, and fixes
MovementHandler writing to those stale members on world portal.

Demotes SMSG_SPELL_START/CAST_RESULT debug logs to LOG_DEBUG.
This commit is contained in:
Kelsi 2026-03-29 16:49:17 -07:00
parent d32b35c583
commit 209c257745
5 changed files with 15 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/game/movement_handler.cpp
View file

@ -1880,10 +1880,6 @@ void MovementHandler::handleNewWorld(network::Packet& packet) {
owner_.stopAutoAttack();
owner_.tabCycleStale = true;
owner_.resetCastState();
owner_.craftQueueSpellId_ = 0;
owner_.craftQueueRemaining_ = 0;
owner_.queuedSpellId_ = 0;
owner_.queuedSpellTarget_ = 0;
if (owner_.socket) {
network::Packet ack(wireOpcode(Opcode::MSG_MOVE_WORLDPORT_ACK));
@ -1935,7 +1931,7 @@ void MovementHandler::handleNewWorld(network::Packet& packet) {
owner_.otherPlayerVisibleItemEntries_.clear();
owner_.otherPlayerVisibleDirty_.clear();
otherPlayerMoveTimeMs_.clear();
owner_.unitCastStates_.clear();
if (owner_.spellHandler_) owner_.spellHandler_->clearUnitCastStates();
owner_.unitAurasCache_.clear();
owner_.clearCombatText();
owner_.getEntityManager().clear();
@ -1949,10 +1945,6 @@ void MovementHandler::handleNewWorld(network::Packet& packet) {
owner_.areaTriggerSuppressFirst_ = true;
owner_.stopAutoAttack();
owner_.resetCastState();
owner_.craftQueueSpellId_ = 0;
owner_.craftQueueRemaining_ = 0;
owner_.queuedSpellId_ = 0;
owner_.queuedSpellTarget_ = 0;
if (owner_.socket) {
network::Packet ack(wireOpcode(Opcode::MSG_MOVE_WORLDPORT_ACK));