phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-23 07:40:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

fix: show descriptive party command error messages

Browse source 
Replace the generic "Party command failed (error N)" message with
WoW-standard error strings for each PartyResult code, matching what
the original client displays (e.g. "Your party is full.", "%s is
already in a group.", "%s is ignoring you.", etc.).
This commit is contained in:
Kelsi 2026-03-13 05:54:01 -07:00
parent b34df01331
commit 2b131548aa
1 changed files with 27 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/game/game_handler.cpp
View file

@ -16835,11 +16835,36 @@ void GameHandler::handlePartyCommandResult(network::Packet& packet) {
if (!PartyCommandResultParser::parse(packet, data)) return;
if (data.result != PartyResult::OK) {
const char* errText = nullptr;
switch (data.result) {
case PartyResult::BAD_PLAYER_NAME: errText = "No player named \"%s\" is currently online."; break;
case PartyResult::TARGET_NOT_IN_GROUP: errText = "%s is not in your group."; break;
case PartyResult::TARGET_NOT_IN_INSTANCE:errText = "%s is not in your instance."; break;
case PartyResult::GROUP_FULL: errText = "Your party is full."; break;
case PartyResult::ALREADY_IN_GROUP: errText = "%s is already in a group."; break;
case PartyResult::NOT_IN_GROUP: errText = "You are not in a group."; break;
case PartyResult::NOT_LEADER: errText = "You are not the group leader."; break;
case PartyResult::PLAYER_WRONG_FACTION: errText = "%s is the wrong faction for this group."; break;
case PartyResult::IGNORING_YOU: errText = "%s is ignoring you."; break;
case PartyResult::LFG_PENDING: errText = "You cannot do that while in a LFG queue."; break;
case PartyResult::INVITE_RESTRICTED: errText = "Target is not accepting group invites."; break;
default: errText = "Party command failed."; break;
}
char buf[256];
if (!data.name.empty() && errText && std::strstr(errText, "%s")) {
std::snprintf(buf, sizeof(buf), errText, data.name.c_str());
} else if (errText) {
std::snprintf(buf, sizeof(buf), "%s", errText);
} else {
std::snprintf(buf, sizeof(buf), "Party command failed (error %u).",
static_cast<uint32_t>(data.result));
}
MessageChatData msg;
msg.type = ChatType::SYSTEM;
msg.language = ChatLanguage::UNIVERSAL;
msg.message = "Party command failed (error " + std::to_string(static_cast<uint32_t>(data.result)) + ")";
if (!data.name.empty()) msg.message += " for " + data.name;
msg.message = buf;
addLocalChatMessage(msg);
}
}