phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 01:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: add Packet::readPackedGuid() and replace 121 static method calls

Browse source 
Move packed GUID reading into Packet class alongside readUInt8/readFloat.
Replace 121 UpdateObjectParser::readPackedGuid(packet) calls with
packet.readPackedGuid() across 4 files, reducing coupling between
Packet and UpdateObjectParser.
This commit is contained in:
Kelsi 2026-03-25 13:58:48 -07:00
parent 3f54d8bcb8
commit 2c79d82446
6 changed files with 133 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/network/packet.cpp
View file

@ -86,6 +86,17 @@ float Packet::readFloat() {
return value;
}
uint64_t Packet::readPackedGuid() {
uint8_t mask = readUInt8();
if (mask == 0) return 0;
uint64_t guid = 0;
for (int i = 0; i < 8; ++i) {
if (mask & (1 << i))
guid |= static_cast<uint64_t>(readUInt8()) << (i * 8);
}
return guid;
}
std::string Packet::readString() {
std::string result;
while (readPos < data.size()) {