phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-10 02:53:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor(editor): extract edge classification into cli_weld

Browse source 
The "loop over triangles, key edges by canonical-vertex pair,
count uses, classify boundary/manifold/non-manifold" pass was
duplicated across cli_mesh_info, cli_world_info, and the new
cli_audits watertight check. Hoist it into cli_weld as
classifyEdges(indices, canon) returning an EdgeStats struct
with boundary / manifold / nonManifold counters and a
watertight() convenience method.

All three callers verified byte-identical:
  • --info-mesh-stats firepit:    180 edges, watertight YES
  • --info-wob-stats cube:        18 manifold, watertight YES
  • --audit-watertight /tmp/...:  61 meshes, 12 failures, rc=12

About 60 more lines of duplication removed; classifyEdges +
buildWeldMap together form the complete reusable surface for
new weld/topology audit commands.
This commit is contained in:
Kelsi 2026-05-09 11:15:31 -07:00
parent 0137ca8707
commit 3cf3b35885
5 changed files with 90 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tools/editor/cli_world_info.cpp
View file

@ -95,10 +95,6 @@ int handleInfoWobStats(int& i, int argc, char** argv) {
return 1;
}
auto bld = wowee::pipeline::WoweeBuildingLoader::load(base);
auto edgeKey = [](uint32_t a, uint32_t b) -> uint64_t {
if (a > b) std::swap(a, b);
return (uint64_t(a) << 32) | uint64_t(b);
};
struct GroupStats {
std::string name;
std::size_t tris = 0;
@ -140,8 +136,7 @@ int handleInfoWobStats(int& i, int argc, char** argv) {
}
gs.uniquePositions = g.vertices.size();
}
std::unordered_map<uint64_t, uint32_t> edgeUses;
edgeUses.reserve(gs.tris * 3);
// Triangle area pass (also catches out-of-range indices).
for (std::size_t t = 0; t < gs.tris; ++t) {
uint32_t i0 = g.indices[t * 3 + 0];
uint32_t i1 = g.indices[t * 3 + 1];
@ -160,17 +155,12 @@ int handleInfoWobStats(int& i, int argc, char** argv) {
double area = 0.5 * glm::length(glm::cross(b - a, c - a));
if (area < 1e-12) ++gs.degenerate;
gs.surfaceArea += area;
uint32_t c0 = canon[i0], c1 = canon[i1], c2 = canon[i2];
if (c0 != c1) ++edgeUses[edgeKey(c0, c1)];
if (c1 != c2) ++edgeUses[edgeKey(c1, c2)];
if (c2 != c0) ++edgeUses[edgeKey(c2, c0)];
}
for (const auto& [_k, count] : edgeUses) {
if (count == 1) ++gs.boundary;
else if (count == 2) ++gs.manifold;
else ++gs.nonManifold;
}
gs.watertight = (gs.boundary == 0 && gs.nonManifold == 0);
EdgeStats edges = classifyEdges(g.indices, canon);
gs.boundary = edges.boundary;
gs.manifold = edges.manifold;
gs.nonManifold = edges.nonManifold;
gs.watertight = edges.watertight();
aggBoundary += gs.boundary;
aggManifold += gs.manifold;
aggNonManifold += gs.nonManifold;