From 3fa495d9ea5bf0376ecb59220da76c607dae9149 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Fri, 13 Mar 2026 19:43:50 -0700 Subject: [PATCH] fix(combatlog): preserve spell ids in spell miss events --- src/game/game_handler.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/game/game_handler.cpp b/src/game/game_handler.cpp index c5dff0ef..d7a81bda 100644 --- a/src/game/game_handler.cpp +++ b/src/game/game_handler.cpp @@ -2656,7 +2656,7 @@ void GameHandler::handlePacket(network::Packet& packet) { }; // spellId prefix present in all expansions if (packet.getSize() - packet.getReadPos() < 4) break; - /*uint32_t spellId =*/ packet.readUInt32(); + uint32_t spellId = packet.readUInt32(); if (packet.getSize() - packet.getReadPos() < (spellMissTbcLike ? 8 : 1)) break; uint64_t casterGuid = readSpellMissGuid(); if (packet.getSize() - packet.getReadPos() < 5) break; @@ -2692,10 +2692,10 @@ void GameHandler::handlePacket(network::Packet& packet) { CombatTextEntry::Type ct = (missInfo < 9) ? missTypes[missInfo] : CombatTextEntry::MISS; if (casterGuid == playerGuid) { // We cast a spell and it missed the target - addCombatText(ct, 0, 0, true, 0, casterGuid, victimGuid); + addCombatText(ct, 0, spellId, true, 0, casterGuid, victimGuid); } else if (victimGuid == playerGuid) { // Enemy spell missed us (we dodged/parried/blocked/resisted/etc.) - addCombatText(ct, 0, 0, false, 0, casterGuid, victimGuid); + addCombatText(ct, 0, spellId, false, 0, casterGuid, victimGuid); } } break;