phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Handle variable LOGON_PROOF failure response sizes

Browse source 
Some servers send 2 bytes for failure, others send 4. Consume up to 4
if available, otherwise accept the 2-byte minimum.
This commit is contained in:
Kelsi 2026-02-05 12:50:05 -08:00
parent 430a213063
commit 45fc9996e2
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/network/tcp_socket.cpp
View file

@ -225,13 +225,14 @@ size_t TCPSocket::getExpectedPacketSize(uint8_t opcode) {
case 0x01: // LOGON_PROOF response
// Success: opcode(1) + status(1) + M2(20) + accountFlags(4) + surveyId(4) + loginFlags(2) = 32
// Failure: opcode(1) + status(1) + padding(2) = 4
// Failure: varies by server — minimum 2 bytes (opcode + status), some send 4
if (receiveBuffer.size() >= 2) {
uint8_t status = receiveBuffer[1];
if (status == 0x00) {
return 32; // Success
return 32; // Success (WotLK 3.3.5a format)
} else {
return 4; // Failure
// Consume up to 4 bytes if available, minimum 2
return (receiveBuffer.size() >= 4) ? 4 : 2;
}
}
return 0; // Need more data