From 46365f4738ac2afcf735a0ef931c3952fc06f6e6 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Wed, 11 Mar 2026 08:42:58 -0700 Subject: [PATCH] fix: correct keybinding defaults to match WoW standard keys The keybinding manager had incorrect default key assignments: - TOGGLE_SPELLBOOK was S (should be P - WoW standard) - TOGGLE_TALENTS was K (should be N - WoW standard) These mismatched the actual hardcoded keys in spellbook_screen.cpp (P) and talent_screen.cpp (N), as well as user expectations from standard WoW. Update keybinding defaults to align with WoW conventions and the actual UI implementations that are using these keys. --- src/ui/keybinding_manager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ui/keybinding_manager.cpp b/src/ui/keybinding_manager.cpp index e4d63e0f..bb2d1021 100644 --- a/src/ui/keybinding_manager.cpp +++ b/src/ui/keybinding_manager.cpp @@ -18,8 +18,8 @@ void KeybindingManager::initializeDefaults() { // Set default keybindings bindings_[static_cast(Action::TOGGLE_CHARACTER_SCREEN)] = ImGuiKey_C; bindings_[static_cast(Action::TOGGLE_INVENTORY)] = ImGuiKey_I; - bindings_[static_cast(Action::TOGGLE_SPELLBOOK)] = ImGuiKey_S; - bindings_[static_cast(Action::TOGGLE_TALENTS)] = ImGuiKey_K; + bindings_[static_cast(Action::TOGGLE_SPELLBOOK)] = ImGuiKey_P; // WoW standard key + bindings_[static_cast(Action::TOGGLE_TALENTS)] = ImGuiKey_N; // WoW standard key bindings_[static_cast(Action::TOGGLE_QUESTS)] = ImGuiKey_L; bindings_[static_cast(Action::TOGGLE_MINIMAP)] = ImGuiKey_M; bindings_[static_cast(Action::TOGGLE_SETTINGS)] = ImGuiKey_Escape;