phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-01 19:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: filter officer chat for non-officers (server sends to all guild members)

Browse source 
Some private servers (AzerothCore/ChromieCraft) send OFFICER chat type
to all guild members regardless of rank. The real WoW client checks the
GR_RIGHT_OFFCHATLISTEN (0x80) guild rank permission before displaying.

Now checks the player's guild rank rights from the roster data and
suppresses officer chat if the permission bit is not set.
This commit is contained in:
Kelsi 2026-03-28 14:45:51 -07:00
parent 21fb2aa11c
commit 4e709692f1
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/game/chat_handler.cpp
View file

@ -196,6 +196,24 @@ void ChatHandler::handleMessageChat(network::Packet& packet) {
}
}
// Filter officer chat if player doesn't have officer chat permission.
// Some servers send officer chat to all guild members regardless of rank.
// WoW guild right bit 0x40 = GR_RIGHT_OFFCHATSPEAK, 0x80 = GR_RIGHT_OFFCHATLISTEN
if (data.type == ChatType::OFFICER) {
const auto& roster = owner_.getGuildRoster();
uint64_t myGuid = owner_.getPlayerGuid();
uint32_t myRankIdx = 0;
for (const auto& m : roster.members) {
if (m.guid == myGuid) { myRankIdx = m.rankIndex; break; }
}
if (myRankIdx < roster.ranks.size()) {
uint32_t rights = roster.ranks[myRankIdx].rights;
if (!(rights & 0x80)) { // GR_RIGHT_OFFCHATLISTEN = 0x80
return; // Don't show officer chat to non-officers
}
}
}
// Filter addon-to-addon whispers (GearScore, DBM, oRA, etc.) from player chat.
// These are invisible in the real WoW client.
if (data.type == ChatType::WHISPER || data.type == ChatType::WHISPER_INFORM) {