phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-05 04:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: SMSG_ITEM_PUSH_RESULT read extra byte causing wrong item count

Browse source 
The handler read an extra uint8 (bag) after bagSlot, shifting all
subsequent fields by 1 byte. This caused count to straddle the count
and countInInventory fields — e.g. count=1 read as 0x03000000 (50M).

Also removes cast bar diagnostic overlay and demotes debug logs.
This commit is contained in:
Kelsi 2026-03-29 17:30:44 -07:00
parent 309fd11a7b
commit 51da88b120
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/game/inventory_handler.cpp
View file

@ -194,18 +194,18 @@ void InventoryHandler::registerOpcodes(DispatchTable& table) {
// ---- Item push result ----
table[Opcode::SMSG_ITEM_PUSH_RESULT] = [this](network::Packet& packet) {
// guid(8)+received(4)+created(4)+?+?+bag(1)+slot(4)+itemId(4)+...+count(4)+...
// WotLK 3.3.5a: guid(8)+received(4)+created(4)+displayInChat(4)+bagSlot(1)
// +slot(4)+itemId(4)+suffixFactor(4)+randomPropertyId(4)+count(4)+countInInventory(4)
if (packet.getSize() - packet.getReadPos() < 45) return;
uint64_t guid = packet.readUInt64();
if (guid != owner_.playerGuid) { packet.setReadPos(packet.getSize()); return; }
/*uint32_t received =*/ packet.readUInt32();
/*uint32_t created =*/ packet.readUInt32();
/*uint32_t unk1 =*/ packet.readUInt32();
/*uint8_t unk2 =*/ packet.readUInt8();
/*uint8_t bag =*/ packet.readUInt8();
/*uint32_t slot =*/ packet.readUInt32();
/*uint32_t received =*/ packet.readUInt32();
/*uint32_t created =*/ packet.readUInt32();
/*uint32_t displayInChat =*/ packet.readUInt32();
/*uint8_t bagSlot =*/ packet.readUInt8();
/*uint32_t slot =*/ packet.readUInt32();
uint32_t itemId = packet.readUInt32();
/*uint32_t propSeed =*/ packet.readUInt32();
/*uint32_t suffixFactor =*/ packet.readUInt32();
int32_t randomProp = static_cast<int32_t>(packet.readUInt32());
uint32_t count = packet.readUInt32();