phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: show item tooltip for /use macros when spell tooltip unavailable

Browse source 
When hovering a /use macro whose item's on-use spell isn't in the DBC
(no rich spell tooltip available), the tooltip fell back to showing raw
macro text. Now searches the item info cache and shows the full item
tooltip (stats, quality, binding, description) as a more useful
fallback for /use macros.
This commit is contained in:
Kelsi 2026-03-20 10:12:42 -07:00
parent 71a3abe5d7
commit 52064eb438
1 changed files with 37 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/ui/game_screen.cpp
View file

@ -9205,13 +9205,43 @@ void GameScreen::renderActionBar(game::GameHandler& gameHandler) {
}
}
if (!showedRich) {
ImGui::Text("Macro #%u", slot.id);
const std::string& macroText = gameHandler.getMacroText(slot.id);
if (!macroText.empty()) {
ImGui::Separator();
ImGui::TextUnformatted(macroText.c_str());
} else {
ImGui::TextDisabled("(no text — right-click to Edit)");
// For /use macros: try showing the item tooltip instead
if (macroIsUseCmd) {
const std::string& macroText = gameHandler.getMacroText(slot.id);
// Extract item name from first /use command
for (const auto& cmd : allMacroCommands(macroText)) {
std::string cl = cmd;
for (char& c : cl) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
if (cl.rfind("/use ", 0) != 0) continue;
size_t sp = cmd.find(' ');
if (sp == std::string::npos) continue;
std::string itemArg = cmd.substr(sp + 1);
while (!itemArg.empty() && itemArg.front() == ' ') itemArg.erase(itemArg.begin());
while (!itemArg.empty() && itemArg.back() == ' ') itemArg.pop_back();
std::string itemLow = itemArg;
for (char& c : itemLow) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
for (const auto& [entry, info] : gameHandler.getItemInfoCache()) {
if (!info.valid) continue;
std::string iName = info.name;
for (char& c : iName) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
if (iName == itemLow) {
inventoryScreen.renderItemTooltip(info);
showedRich = true;
break;
}
}
break;
}
}
if (!showedRich) {
ImGui::Text("Macro #%u", slot.id);
const std::string& macroText = gameHandler.getMacroText(slot.id);
if (!macroText.empty()) {
ImGui::Separator();
ImGui::TextUnformatted(macroText.c_str());
} else {
ImGui::TextDisabled("(no text — right-click to Edit)");
}
}
}
ImGui::EndTooltip();