Optimize login music scanning and warden debug formatting

include/ui/auth_screen.hpp

@@ -121,6 +121,8 @@ private:
     bool musicInitAttempted = false;
     bool musicPlaying = false;
     bool missingIntroTracksLogged_ = false;
+    bool introTracksScanned_ = false;
+    std::vector<std::string> introTracks_;
     bool loginMusicVolumeAdjusted_ = false;
     int savedMusicVolume_ = 30;
 };

src/game/game_handler.cpp

@@ -3512,16 +3512,19 @@ void GameHandler::handleWardenData(network::Packet& packet) {
     // Decrypt the payload
     std::vector<uint8_t> decrypted = wardenCrypto_->decrypt(data);
 
-    // Log decrypted data
+    // Avoid expensive hex formatting when DEBUG logs are disabled.
-    {
+    if (core::Logger::getInstance().shouldLog(core::LogLevel::DEBUG)) {
         std::string hex;
         size_t logSize = std::min(decrypted.size(), size_t(256));
         hex.reserve(logSize * 3);
         for (size_t i = 0; i < logSize; ++i) {
-            char b[4]; snprintf(b, sizeof(b), "%02x ", decrypted[i]); hex += b;
+            char b[4];
+            snprintf(b, sizeof(b), "%02x ", decrypted[i]);
+            hex += b;
         }
-        if (decrypted.size() > 64)
+        if (decrypted.size() > 64) {
             hex += "... (" + std::to_string(decrypted.size() - 64) + " more)";
+        }
         LOG_DEBUG("Warden: Decrypted (", decrypted.size(), " bytes): ", hex);
     }
 

src/ui/auth_screen.cpp

@@ -220,6 +220,9 @@ void AuthScreen::render(auth::AuthHandler& authHandler) {
             music->update(ImGui::GetIO().DeltaTime);
             if (!music->isPlaying()) {
                 static std::mt19937 rng(std::random_device{}());
+                if (!introTracksScanned_) {
+                    introTracksScanned_ = true;
+
                     // Tracks in assets/ root
                     static const std::array<const char*, 1> kRootTracks = {
                         "Raise the Mug, Sound the Warcry.mp3",
@@ -239,38 +242,46 @@ void AuthScreen::render(auth::AuthHandler& authHandler) {
                         "You No Take Candle!.mp3",
                     };
 
-                std::vector<std::string> availableTracks;
                     auto tryAddTrack = [&](const std::filesystem::path& base, const char* track) {
                         std::filesystem::path p = base / track;
                         if (std::filesystem::exists(p)) {
-                        availableTracks.push_back(p.string());
+                            introTracks_.push_back(p.string());
                         }
                     };
                     for (const char* track : kRootTracks) {
                         tryAddTrack("assets", track);
-                    if (availableTracks.empty())
+                        if (introTracks_.empty()) {
                             tryAddTrack(std::filesystem::current_path() / "assets", track);
                         }
+                    }
                     for (const char* track : kOriginalTracks) {
                         tryAddTrack(std::filesystem::path("assets") / "Original Music", track);
                         tryAddTrack(std::filesystem::current_path() / "assets" / "Original Music", track);
                     }
 
-                if (!availableTracks.empty()) {
+                    std::sort(introTracks_.begin(), introTracks_.end());
-                    std::uniform_int_distribution<size_t> pick(0, availableTracks.size() - 1);
+                    introTracks_.erase(std::unique(introTracks_.begin(), introTracks_.end()), introTracks_.end());
-                    const std::string& path = availableTracks[pick(rng)];
+                }
+
+                if (!introTracks_.empty()) {
+                    std::uniform_int_distribution<size_t> pick(0, introTracks_.size() - 1);
+                    const size_t idx = pick(rng);
+                    const std::string path = introTracks_[idx];
                     music->playFilePath(path, true, 1800.0f);
-                    LOG_INFO("AuthScreen: Playing login intro track: ", path);
                     musicPlaying = music->isPlaying();
+                    if (musicPlaying) {
+                        LOG_INFO("AuthScreen: Playing login intro track: ", path);
                     } else {
-                    if (!missingIntroTracksLogged_) {
+                        // Drop bad paths to avoid retrying the same failed file every frame.
+                        introTracks_.erase(introTracks_.begin() + idx);
+                    }
+                } else if (!missingIntroTracksLogged_) {
                     LOG_WARNING("AuthScreen: No login intro tracks found in assets/");
                     missingIntroTracksLogged_ = true;
                 }
             }
         }
     }
-    }
 
     ImGui::SetNextWindowSize(ImVec2(500, 400), ImGuiCond_FirstUseEver);
     ImGui::Begin("Authentication", nullptr, ImGuiWindowFlags_NoCollapse);