phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-14 16:33:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(animation): re-probe capabilities on melee swing, add combat diagnostics

Browse source 
If the capability probe ran before the model was fully loaded, all melee
animation IDs would be 0 and auto-attack swings would silently fall back
to STAND (no visible animation). Now re-probes when a melee swing fires
but hasMelee is false.

Added WARNING-level logging to triggerMeleeSwing and CombatFSM to
diagnose the night elf stationary combat animation issue.
This commit is contained in:
Kelsi 2026-04-05 17:52:18 -07:00
parent 696baffdf7
commit 53639f9592
2 changed files with 28 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/rendering/animation_controller.cpp
View file

@ -245,6 +245,18 @@ void AnimationController::triggerMeleeSwing() {
if (durationSec < 0.25f) durationSec = 0.25f;
if (durationSec > 1.0f) durationSec = 1.0f;
meleeSwingTimer_ = durationSec;
// Diagnostic: log the melee swing trigger with key state
const auto& caps = characterAnimator_.getCapabilities();
auto* cc = renderer_->getCameraController();
LOG_WARNING("triggerMeleeSwing: meleeAnimId=", meleeAnimId_,
" dur=", durationSec,
" caps.melee1H=", caps.resolvedMelee1H,
" caps.melee2H=", caps.resolvedMelee2H,
" caps.meleeUnarmed=", caps.resolvedMeleeUnarmed,
" grounded=", (cc ? cc->isGrounded() : false),
" probed=", capabilitiesProbed_);
if (renderer_->getAudioCoordinator()->getActivitySoundManager()) {
renderer_->getAudioCoordinator()->getActivitySoundManager()->playMeleeSwing();
}
@ -1043,9 +1055,17 @@ void AnimationController::updateCharacterAnimation() {
auto* cameraController = renderer_->getCameraController();
uint32_t characterInstanceId = renderer_->getCharacterInstanceId();
// Lazy probe: populate capability set once per model
if (!capabilitiesProbed_ && characterRenderer && characterInstanceId != 0) {
probeCapabilities();
// Lazy probe: populate capability set once per model.
// Re-probe if melee capabilities are missing (model may not have been fully
// loaded on the first probe attempt).
if (characterRenderer && characterInstanceId != 0) {
if (!capabilitiesProbed_) {
probeCapabilities();
} else if (meleeSwingTimer_ > 0.0f && !characterAnimator_.getCapabilities().hasMelee) {
LOG_WARNING("Re-probing capabilities: melee swing active but hasMelee=false");
capabilitiesProbed_ = false;
probeCapabilities();
}
}
// When mounted, delegate to MountFSM and handle positioning