From 560c4a40c06b0aea1ac9932314c66e9481f6f7e0 Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Tue, 5 May 2026 09:11:46 -0700
Subject: [PATCH] fix(editor): About dialog now works, moved outside menu bar
 scope
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- About dialog was broken because ImGui::OpenPopup inside BeginMenu
  has wrong ID scope — popup never appeared
- Changed to a proper ImGui::Begin window with showAbout_ flag
- Closeable with X button or clicking About again
- Shows version, author, feature summary, and tech stack
---
 tools/editor/editor_ui.cpp | 15 +++++++++------
 tools/editor/editor_ui.hpp |  1 +
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/tools/editor/editor_ui.cpp b/tools/editor/editor_ui.cpp
index e7542b97..c5aae845 100644
--- a/tools/editor/editor_ui.cpp
+++ b/tools/editor/editor_ui.cpp
@@ -216,12 +216,16 @@ void EditorUI::renderMenuBar(EditorApp& app) {
         if (ImGui::BeginMenu("Help")) {
             if (ImGui::MenuItem("Keyboard Shortcuts", "F1")) showHelp_ = !showHelp_;
             ImGui::Separator();
-            if (ImGui::MenuItem("About Wowee Editor")) {
-                ImGui::OpenPopup("AboutEditor");
-            }
+            if (ImGui::MenuItem("About Wowee Editor")) showAbout_ = true;
             ImGui::EndMenu();
         }
-        if (ImGui::BeginPopup("AboutEditor")) {
+        ImGui::EndMainMenuBar();
+    }
+
+    // About dialog (must be outside menu bar scope)
+    if (showAbout_) {
+        ImGui::SetNextWindowSize(ImVec2(350, 250), ImGuiCond_FirstUseEver);
+        if (ImGui::Begin("About Wowee World Editor", &showAbout_)) {
             ImGui::Text("Wowee World Editor");
             ImGui::Text("by Kelsi Davis");
             ImGui::Separator();
@@ -233,9 +237,8 @@ void EditorUI::renderMenuBar(EditorApp& app) {
             ImGui::Text("Export: ADT + WDT + JSON (zone manifest)");
             ImGui::Text("9k+ lines, WoW 3.3.5a ADT/WDT format");
             ImGui::Text("Built with SDL2 / Vulkan / ImGui");
-            ImGui::EndPopup();
         }
-        ImGui::EndMainMenuBar();
+        ImGui::End();
     }
 
     // Help overlay
diff --git a/tools/editor/editor_ui.hpp b/tools/editor/editor_ui.hpp
index ee141e49..5aea612f 100644
--- a/tools/editor/editor_ui.hpp
+++ b/tools/editor/editor_ui.hpp
@@ -43,6 +43,7 @@ private:
     bool showLoadDialog_ = false;
     bool showSaveDialog_ = false;
     bool showHelp_ = false;
+    bool showAbout_ = false;
 
     char newMapNameBuf_[256] = "CustomZone";
     int newTileX_ = 32;