phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-11 11:33:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat(pipeline): add WCRR (Wowee Combat Rating Conversion) catalog

Browse source 
65th open format — replaces gtCombatRatings.dbc plus the
per-level rating-to-percentage tables in gtRegenHPPerSpt.dbc
and related stat-curve DBCs. Defines per-rating-type
conversion factors at canonical level breakpoints (1 / 60
/ 70 / 80) — the runtime linearly interpolates between
breakpoints for intermediate levels.

pointsAtLevelN is "how many rating points equal 1% of the
benefit at that level." Higher level = more rating needed
for the same %. Standard WoW WotLK example: 14 crit rating
= 1% crit at L60, but 45.91 = 1% at L80.

5 rating kinds (Combat / Defense / Spell / Resilience /
Other) classify what stat resolver category each rating
belongs to.

CLI: --gen-crr (3 essential combat ratings — Hit/Crit/Haste
at canonical WoW WotLK conversion values), --gen-crr-defensive
(4 defensive — Defense/Dodge/Parry/Block with diminishing-
returns soft-cap percentages), --gen-crr-spell (3 spell —
SpellPower direct 1:1, SpellPenetration flat, MP5 mana
regen), --info-wcrr, --validate-wcrr with --json variants.
Validator catches id+name required, kind 0..4, all
pointsAtLN > 0 (otherwise stat resolver would div-by-zero),
maxBenefitPercent > 0 (rating would never grant any
benefit), and non-monotonic conversion curve warning
(rating cost typically ascends with level for non-flat
ratings like SpellPower).

Format graph: 64 → 65 binary formats. CLI flag count: 861
→ 868.
This commit is contained in:
Kelsi 2026-05-09 21:11:26 -07:00
parent 8be7ac1b5e
commit 5865421b00
10 changed files with 630 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

252
tools/editor/cli_combat_ratings_catalog.cpp Normal file
View file

@ -0,0 +1,252 @@
#include "cli_combat_ratings_catalog.hpp"
#include "cli_arg_parse.hpp"
#include "cli_box_emitter.hpp"
#include "pipeline/wowee_combat_ratings.hpp"
#include <nlohmann/json.hpp>
#include <cstdint>
#include <cstdio>
#include <cstring>
#include <fstream>
#include <string>
#include <vector>
namespace wowee {
namespace editor {
namespace cli {
namespace {
std::string stripWcrrExt(std::string base) {
stripExt(base, ".wcrr");
return base;
}
bool saveOrError(const wowee::pipeline::WoweeCombatRating& c,
const std::string& base, const char* cmd) {
if (!wowee::pipeline::WoweeCombatRatingLoader::save(c, base)) {
std::fprintf(stderr, "%s: failed to save %s.wcrr\n",
cmd, base.c_str());
return false;
}
return true;
}
void printGenSummary(const wowee::pipeline::WoweeCombatRating& c,
const std::string& base) {
std::printf("Wrote %s.wcrr\n", base.c_str());
std::printf(" catalog : %s\n", c.name.c_str());
std::printf(" ratings : %zu\n", c.entries.size());
}
int handleGenStarter(int& i, int argc, char** argv) {
std::string base = argv[++i];
std::string name = "StarterCombatRatings";
if (parseOptArg(i, argc, argv)) name = argv[++i];
base = stripWcrrExt(base);
auto c = wowee::pipeline::WoweeCombatRatingLoader::makeStarter(name);
if (!saveOrError(c, base, "gen-crr")) return 1;
printGenSummary(c, base);
return 0;
}
int handleGenDefensive(int& i, int argc, char** argv) {
std::string base = argv[++i];
std::string name = "DefensiveCombatRatings";
if (parseOptArg(i, argc, argv)) name = argv[++i];
base = stripWcrrExt(base);
auto c = wowee::pipeline::WoweeCombatRatingLoader::makeDefensive(name);
if (!saveOrError(c, base, "gen-crr-defensive")) return 1;
printGenSummary(c, base);
return 0;
}
int handleGenSpell(int& i, int argc, char** argv) {
std::string base = argv[++i];
std::string name = "SpellCombatRatings";
if (parseOptArg(i, argc, argv)) name = argv[++i];
base = stripWcrrExt(base);
auto c = wowee::pipeline::WoweeCombatRatingLoader::makeSpell(name);
if (!saveOrError(c, base, "gen-crr-spell")) return 1;
printGenSummary(c, base);
return 0;
}
int handleInfo(int& i, int argc, char** argv) {
std::string base = argv[++i];
bool jsonOut = consumeJsonFlag(i, argc, argv);
base = stripWcrrExt(base);
if (!wowee::pipeline::WoweeCombatRatingLoader::exists(base)) {
std::fprintf(stderr, "WCRR not found: %s.wcrr\n", base.c_str());
return 1;
}
auto c = wowee::pipeline::WoweeCombatRatingLoader::load(base);
if (jsonOut) {
nlohmann::json j;
j["wcrr"] = base + ".wcrr";
j["name"] = c.name;
j["count"] = c.entries.size();
nlohmann::json arr = nlohmann::json::array();
for (const auto& e : c.entries) {
arr.push_back({
{"ratingType", e.ratingType},
{"name", e.name},
{"description", e.description},
{"iconPath", e.iconPath},
{"ratingKind", e.ratingKind},
{"ratingKindName", wowee::pipeline::WoweeCombatRating::ratingKindName(e.ratingKind)},
{"pointsAtL1", e.pointsAtL1},
{"pointsAtL60", e.pointsAtL60},
{"pointsAtL70", e.pointsAtL70},
{"pointsAtL80", e.pointsAtL80},
{"maxBenefitPercent", e.maxBenefitPercent},
});
}
j["entries"] = arr;
std::printf("%s\n", j.dump(2).c_str());
return 0;
}
std::printf("WCRR: %s.wcrr\n", base.c_str());
std::printf(" catalog : %s\n", c.name.c_str());
std::printf(" ratings : %zu\n", c.entries.size());
if (c.entries.empty()) return 0;
std::printf(" id kind L1 L60 L70 L80 maxPct name\n");
for (const auto& e : c.entries) {
std::printf(" %4u %-9s %5.2f %5.2f %5.2f %6.2f %5.1f %s\n",
e.ratingType,
wowee::pipeline::WoweeCombatRating::ratingKindName(e.ratingKind),
e.pointsAtL1, e.pointsAtL60, e.pointsAtL70,
e.pointsAtL80, e.maxBenefitPercent,
e.name.c_str());
}
std::printf(" legend: pointsAtLN = how many rating points = 1%% benefit at level N\n");
return 0;
}
int handleValidate(int& i, int argc, char** argv) {
std::string base = argv[++i];
bool jsonOut = consumeJsonFlag(i, argc, argv);
base = stripWcrrExt(base);
if (!wowee::pipeline::WoweeCombatRatingLoader::exists(base)) {
std::fprintf(stderr,
"validate-wcrr: WCRR not found: %s.wcrr\n", base.c_str());
return 1;
}
auto c = wowee::pipeline::WoweeCombatRatingLoader::load(base);
std::vector<std::string> errors;
std::vector<std::string> warnings;
if (c.entries.empty()) {
warnings.push_back("catalog has zero entries");
}
std::vector<uint32_t> idsSeen;
for (size_t k = 0; k < c.entries.size(); ++k) {
const auto& e = c.entries[k];
std::string ctx = "entry " + std::to_string(k) +
" (id=" + std::to_string(e.ratingType);
if (!e.name.empty()) ctx += " " + e.name;
ctx += ")";
if (e.ratingType == 0)
errors.push_back(ctx + ": ratingType is 0");
if (e.name.empty())
errors.push_back(ctx + ": name is empty");
if (e.ratingKind > wowee::pipeline::WoweeCombatRating::Other) {
errors.push_back(ctx + ": ratingKind " +
std::to_string(e.ratingKind) + " not in 0..4");
}
// Conversion floor must be > 0 — division by zero
// would crash the stat resolver.
if (e.pointsAtL1 <= 0.0f || e.pointsAtL60 <= 0.0f ||
e.pointsAtL70 <= 0.0f || e.pointsAtL80 <= 0.0f) {
errors.push_back(ctx +
": one or more pointsAtLN values <= 0 "
"(divide-by-zero risk in stat resolver)");
}
if (e.maxBenefitPercent <= 0.0f) {
errors.push_back(ctx +
": maxBenefitPercent " +
std::to_string(e.maxBenefitPercent) +
" <= 0 (rating would never grant any benefit)");
}
// The conversion curve should be monotonic-ascending
// (more rating needed at higher levels). A flat or
// descending curve is plausible only for direct 1:1
// ratings (SpellPower / SpellPenetration / MP5).
bool flat = e.pointsAtL1 == e.pointsAtL60 &&
e.pointsAtL60 == e.pointsAtL70 &&
e.pointsAtL70 == e.pointsAtL80;
bool ascending = e.pointsAtL1 <= e.pointsAtL60 &&
e.pointsAtL60 <= e.pointsAtL70 &&
e.pointsAtL70 <= e.pointsAtL80;
if (!flat && !ascending) {
warnings.push_back(ctx +
": conversion curve non-monotonic (" +
std::to_string(e.pointsAtL1) + " / " +
std::to_string(e.pointsAtL60) + " / " +
std::to_string(e.pointsAtL70) + " / " +
std::to_string(e.pointsAtL80) +
") — typically rating cost ascends with level");
}
for (uint32_t prev : idsSeen) {
if (prev == e.ratingType) {
errors.push_back(ctx + ": duplicate ratingType");
break;
}
}
idsSeen.push_back(e.ratingType);
}
bool ok = errors.empty();
if (jsonOut) {
nlohmann::json j;
j["wcrr"] = base + ".wcrr";
j["ok"] = ok;
j["errors"] = errors;
j["warnings"] = warnings;
std::printf("%s\n", j.dump(2).c_str());
return ok ? 0 : 1;
}
std::printf("validate-wcrr: %s.wcrr\n", base.c_str());
if (ok && warnings.empty()) {
std::printf(" OK — %zu ratings, all ratingTypes unique, all curves monotonic\n",
c.entries.size());
return 0;
}
if (!warnings.empty()) {
std::printf(" warnings (%zu):\n", warnings.size());
for (const auto& w : warnings)
std::printf(" - %s\n", w.c_str());
}
if (!errors.empty()) {
std::printf(" ERRORS (%zu):\n", errors.size());
for (const auto& e : errors)
std::printf(" - %s\n", e.c_str());
}
return ok ? 0 : 1;
}
} // namespace
bool handleCombatRatingsCatalog(int& i, int argc, char** argv,
int& outRc) {
if (std::strcmp(argv[i], "--gen-crr") == 0 && i + 1 < argc) {
outRc = handleGenStarter(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--gen-crr-defensive") == 0 &&
i + 1 < argc) {
outRc = handleGenDefensive(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--gen-crr-spell") == 0 && i + 1 < argc) {
outRc = handleGenSpell(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--info-wcrr") == 0 && i + 1 < argc) {
outRc = handleInfo(i, argc, argv); return true;
}
if (std::strcmp(argv[i], "--validate-wcrr") == 0 && i + 1 < argc) {
outRc = handleValidate(i, argc, argv); return true;
}
return false;
}
} // namespace cli
} // namespace editor
} // namespace wowee