phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-03 00:03:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: ::toupper/::tolower UB on signed char at 5 remaining call sites

Browse source 
std::toupper(int) and std::tolower(int) have undefined behavior when
passed a negative value. These sites passed raw signed char without
casting to unsigned char first, unlike the rest of the codebase which
already uses the correct pattern. Affects auth (account names), world
packets, and mount sound path matching.
This commit is contained in:
Kelsi 2026-03-29 19:58:36 -07:00
parent d776226fd1
commit 59bbeaca62
4 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/audio/mount_sound_manager.cpp
View file

@ -495,7 +495,7 @@ MountType MountSoundManager::detectMountType(uint32_t creatureDisplayId) const {
MountFamily MountSoundManager::detectMountFamilyFromPath(const std::string& modelPath) const {
// Convert path to lowercase for matching
std::string lower = modelPath;
for (char& c : lower) c = std::tolower(c);
for (char& c : lower) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
// Check creature model path for family keywords
if (lower.find("tallstrider") != std::string::npos ||