mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-04-17 01:23:51 +00:00
fix: ::toupper/::tolower UB on signed char at 5 remaining call sites
std::toupper(int) and std::tolower(int) have undefined behavior when passed a negative value. These sites passed raw signed char without casting to unsigned char first, unlike the rest of the codebase which already uses the correct pattern. Affects auth (account names), world packets, and mount sound path matching.
This commit is contained in:
parent
d776226fd1
commit
59bbeaca62
4 changed files with 7 additions and 5 deletions
|
|
@ -80,7 +80,7 @@ network::Packet AuthSessionPacket::build(uint32_t build,
|
|||
// Convert account name to uppercase
|
||||
std::string upperAccount = accountName;
|
||||
std::transform(upperAccount.begin(), upperAccount.end(),
|
||||
upperAccount.begin(), ::toupper);
|
||||
upperAccount.begin(), [](unsigned char c) { return static_cast<char>(std::toupper(c)); });
|
||||
|
||||
LOG_INFO("Building CMSG_AUTH_SESSION for account: ", upperAccount);
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue