phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 17:43:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(combatlog): validate packed guid bounds in spell go parser

Browse source
This commit is contained in:
Kelsi 2026-03-14 10:40:54 -07:00
parent 4561eb8696
commit 5a9be91fac
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/game/world_packets.cpp
View file

@ -3722,7 +3722,14 @@ bool SpellGoParser::parse(network::Packet& packet, SpellGoData& data) {
if (packet.getSize() - packet.getReadPos() < 17) return false; if (packet.getSize() - packet.getReadPos() < 17) return false;
size_t startPos = packet.getReadPos(); size_t startPos = packet.getReadPos();
if (!hasFullPackedGuid(packet)) {
return false;
}
data.casterGuid = UpdateObjectParser::readPackedGuid(packet); data.casterGuid = UpdateObjectParser::readPackedGuid(packet);
if (!hasFullPackedGuid(packet)) {
packet.setReadPos(startPos);
return false;
}
data.casterUnit = UpdateObjectParser::readPackedGuid(packet); data.casterUnit = UpdateObjectParser::readPackedGuid(packet);
// Validate remaining fixed fields up to hitCount/missCount // Validate remaining fixed fields up to hitCount/missCount