Fix auth protocol to match real WoW 3.3.5a client format

Three critical bugs fixed:
- LOGON_CHALLENGE request: set protocol byte to 0x03 (was 0x00) and
  reverse FourCC strings (game/platform/os/locale) to match real client
- Response parsers: remove double-read of opcode byte that shifted all
  field reads by one, preventing successful auth with real servers
- LOGON_PROOF response sizes: success=32 bytes, failure=4 bytes to match
  TrinityCore/AzerothCore format

Also adds missing auth result codes (0x13-0x20, 0xFF) including
IGR_WITHOUT_BNET (0x17) which Warmane was returning.
This commit is contained in:
Kelsi 2026-02-05 12:39:34 -08:00
parent 1b414d24d8
commit 5ef11fdc7d
4 changed files with 53 additions and 52 deletions

View file

@ -35,6 +35,15 @@ enum class AuthResult : uint8_t {
LOCK_ENFORCED = 0x10,
TRIAL_EXPIRED = 0x11,
BATTLE_NET = 0x12,
ANTI_INDULGENCE = 0x13,
EXPIRED = 0x14,
NO_GAME_ACCOUNT = 0x15,
CHARGEBACK = 0x16,
IGR_WITHOUT_BNET = 0x17,
GAME_ACCOUNT_LOCKED = 0x18,
UNLOCKABLE_LOCK = 0x19,
CONVERSION_REQUIRED = 0x20,
DISCONNECTED = 0xFF,
};
const char* getAuthResultString(AuthResult result);