phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: fire talent/spell events correctly when learning talents

Browse source 
Fix bug where learning a talent caused an early return before firing
LEARNED_SPELL_IN_TAB and SPELLS_CHANGED events, leaving talent addons
unaware of changes. Now talent learning fires CHARACTER_POINTS_CHANGED,
PLAYER_TALENT_UPDATE, LEARNED_SPELL_IN_TAB, and SPELLS_CHANGED.

Also fire CHARACTER_POINTS_CHANGED, ACTIVE_TALENT_GROUP_CHANGED, and
PLAYER_TALENT_UPDATE from handleTalentsInfo (SMSG_TALENTS_INFO), so
talent addons update when the full talent state is received from the
server (login, spec switch, respec).

Also fire UNIT_HEALTH/UNIT_POWER events from SMSG_HEALTH_UPDATE and
SMSG_POWER_UPDATE packets for real-time unit frame updates.
This commit is contained in:
Kelsi 2026-03-21 02:29:48 -07:00
parent d75f2c62e5
commit 60904e2e15
1 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/game/game_handler.cpp
View file

@ -19524,6 +19524,7 @@ void GameHandler::handleLearnedSpell(network::Packet& packet) {
LOG_INFO("Learned spell: ", spellId, alreadyKnown ? " (already known, skipping chat)" : ""); LOG_INFO("Learned spell: ", spellId, alreadyKnown ? " (already known, skipping chat)" : "");
// Check if this spell corresponds to a talent rank // Check if this spell corresponds to a talent rank
bool isTalentSpell = false;
for (const auto& [talentId, talent] : talentCache_) { for (const auto& [talentId, talent] : talentCache_) {
for (int rank = 0; rank < 5; ++rank) { for (int rank = 0; rank < 5; ++rank) {
if (talent.rankSpells[rank] == spellId) { if (talent.rankSpells[rank] == spellId) {
@ -19532,9 +19533,15 @@ void GameHandler::handleLearnedSpell(network::Packet& packet) {
learnedTalents_[activeTalentSpec_][talentId] = newRank; learnedTalents_[activeTalentSpec_][talentId] = newRank;
LOG_INFO("Talent learned: id=", talentId, " rank=", (int)newRank, LOG_INFO("Talent learned: id=", talentId, " rank=", (int)newRank,
" (spell ", spellId, ") in spec ", (int)activeTalentSpec_); " (spell ", spellId, ") in spec ", (int)activeTalentSpec_);
return; isTalentSpell = true;
if (addonEventCallback_) {
addonEventCallback_("CHARACTER_POINTS_CHANGED", {});
addonEventCallback_("PLAYER_TALENT_UPDATE", {});
}
break;
} }
} }
if (isTalentSpell) break;
} }
// Fire LEARNED_SPELL_IN_TAB / SPELLS_CHANGED for Lua addons // Fire LEARNED_SPELL_IN_TAB / SPELLS_CHANGED for Lua addons
@ -19543,6 +19550,8 @@ void GameHandler::handleLearnedSpell(network::Packet& packet) {
addonEventCallback_("SPELLS_CHANGED", {}); addonEventCallback_("SPELLS_CHANGED", {});
} }
if (isTalentSpell) return; // talent spells don't show chat message
// Show chat message for non-talent spells, but only if not already announced by // Show chat message for non-talent spells, but only if not already announced by
// SMSG_TRAINER_BUY_SUCCEEDED (which pre-inserts into knownSpells). // SMSG_TRAINER_BUY_SUCCEEDED (which pre-inserts into knownSpells).
if (!alreadyKnown) { if (!alreadyKnown) {
@ -19720,6 +19729,13 @@ void GameHandler::handleTalentsInfo(network::Packet& packet) {
" groups=", (int)talentGroupCount, " active=", (int)activeTalentGroup, " groups=", (int)talentGroupCount, " active=", (int)activeTalentGroup,
" learned=", learnedTalents_[activeTalentGroup].size()); " learned=", learnedTalents_[activeTalentGroup].size());
// Fire talent-related events for addons
if (addonEventCallback_) {
addonEventCallback_("CHARACTER_POINTS_CHANGED", {});
addonEventCallback_("ACTIVE_TALENT_GROUP_CHANGED", {});
addonEventCallback_("PLAYER_TALENT_UPDATE", {});
}
if (!talentsInitialized_) { if (!talentsInitialized_) {
talentsInitialized_ = true; talentsInitialized_ = true;
if (unspentTalents > 0) { if (unspentTalents > 0) {