phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-07 01:23:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(m2): NaN guards on setInstancePosition and setInstanceTransform

Browse source 
Same boundary-rejection pattern as createInstance. NaN in either
function would corrupt the spatial grid (stale cells pointing at
NaN-bounded instances) and the GPU model-matrix UBO.
This commit is contained in:
Kelsi 2026-05-06 08:34:53 -07:00
parent f96ea12fe7
commit 61116e94a5
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/rendering/m2_renderer_instance.cpp
View file

@ -33,6 +33,8 @@ thread_local std::vector<uint32_t> tl_m2_collisionTriScratch;
} // namespace m2_internal
void M2Renderer::setInstancePosition(uint32_t instanceId, const glm::vec3& position) {
if (!std::isfinite(position.x) || !std::isfinite(position.y) ||
!std::isfinite(position.z)) return;
auto idxIt = instanceIndexById.find(instanceId);
if (idxIt == instanceIndexById.end()) return;
auto& inst = instances[idxIt->second];
@ -132,6 +134,12 @@ float M2Renderer::getInstanceAnimDuration(uint32_t instanceId) const {
void M2Renderer::setInstanceTransform(uint32_t instanceId, const glm::mat4& transform) {
auto idxIt = instanceIndexById.find(instanceId);
if (idxIt == instanceIndexById.end()) return;
// Reject NaN matrix — would propagate into the model matrix uniform
// and the spatial-grid bounds, leaving stale grid cells pointing at
// a NaN-bounded instance.
for (int c = 0; c < 4; c++)
for (int r = 0; r < 4; r++)
if (!std::isfinite(transform[c][r])) return;
auto& inst = instances[idxIt->second];
// Remove old grid cells before updating bounds