From 67c8101f6725ee7ff96bb2d2ef42143146e85c4a Mon Sep 17 00:00:00 2001 From: Kelsi Date: Tue, 17 Mar 2026 21:08:02 -0700 Subject: [PATCH] fix: add missing TOGGLE_SKILLS to keybinding_manager (fixes CI build failure) --- include/ui/keybinding_manager.hpp | 1 + src/ui/keybinding_manager.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/include/ui/keybinding_manager.hpp b/include/ui/keybinding_manager.hpp index e242ae5d..3c67b125 100644 --- a/include/ui/keybinding_manager.hpp +++ b/include/ui/keybinding_manager.hpp @@ -30,6 +30,7 @@ public: TOGGLE_NAMEPLATES, TOGGLE_RAID_FRAMES, TOGGLE_ACHIEVEMENTS, + TOGGLE_SKILLS, ACTION_COUNT }; diff --git a/src/ui/keybinding_manager.cpp b/src/ui/keybinding_manager.cpp index b522e671..a7f52a3b 100644 --- a/src/ui/keybinding_manager.cpp +++ b/src/ui/keybinding_manager.cpp @@ -36,6 +36,7 @@ void KeybindingManager::initializeDefaults() { bindings_[static_cast(Action::TOGGLE_NAMEPLATES)] = ImGuiKey_V; bindings_[static_cast(Action::TOGGLE_RAID_FRAMES)] = ImGuiKey_F; // Reassigned from R (now camera reset) bindings_[static_cast(Action::TOGGLE_ACHIEVEMENTS)] = ImGuiKey_Y; // WoW standard key (Shift+Y in retail) + bindings_[static_cast(Action::TOGGLE_SKILLS)] = ImGuiKey_K; // WoW standard: K opens Skills/Professions } bool KeybindingManager::isActionPressed(Action action, bool repeat) { @@ -93,6 +94,7 @@ const char* KeybindingManager::getActionName(Action action) { case Action::TOGGLE_NAMEPLATES: return "Nameplates"; case Action::TOGGLE_RAID_FRAMES: return "Raid Frames"; case Action::TOGGLE_ACHIEVEMENTS: return "Achievements"; + case Action::TOGGLE_SKILLS: return "Skills / Professions"; case Action::ACTION_COUNT: break; } return "Unknown"; @@ -158,6 +160,7 @@ void KeybindingManager::loadFromConfigFile(const std::string& filePath) { else if (action == "toggle_raid_frames") actionIdx = static_cast(Action::TOGGLE_RAID_FRAMES); else if (action == "toggle_quest_log") actionIdx = static_cast(Action::TOGGLE_QUESTS); // legacy alias else if (action == "toggle_achievements") actionIdx = static_cast(Action::TOGGLE_ACHIEVEMENTS); + else if (action == "toggle_skills") actionIdx = static_cast(Action::TOGGLE_SKILLS); if (actionIdx < 0) continue; @@ -254,6 +257,7 @@ void KeybindingManager::saveToConfigFile(const std::string& filePath) const { {Action::TOGGLE_NAMEPLATES, "toggle_nameplates"}, {Action::TOGGLE_RAID_FRAMES, "toggle_raid_frames"}, {Action::TOGGLE_ACHIEVEMENTS, "toggle_achievements"}, + {Action::TOGGLE_SKILLS, "toggle_skills"}, }; for (const auto& [action, nameStr] : actionMap) {