From 682f47f66b23dc8c3b1bd92d4587acf945b4423a Mon Sep 17 00:00:00 2001 From: Kelsi Date: Tue, 10 Mar 2026 05:09:43 -0700 Subject: [PATCH] game: downgrade high-frequency per-interaction LOG_INFO/WARNING to LOG_DEBUG MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Demote parse-level diagnostic logs that fire on every game interaction: - TBC/Classic gossip, quest details, quest rewards: LOG_INFO → LOG_DEBUG - WotLK gossip, quest details/reward/request-items: LOG_INFO → LOG_DEBUG - Attack start/stop, XP gain, loot, name query, vendor, party: LOG_INFO → LOG_DEBUG - TBC SMSG_UPDATE_OBJECT has_transport fallback: LOG_WARNING → LOG_DEBUG - TBC parseAuraUpdate not-in-TBC diagnostic: LOG_WARNING → LOG_DEBUG - Turtle SMSG_MONSTER_MOVE WotLK fallback: LOG_WARNING → LOG_DEBUG These all fire multiple times per second during normal gameplay. --- src/game/packet_parsers_classic.cpp | 4 ++-- src/game/packet_parsers_tbc.cpp | 10 +++++----- src/game/world_packets.cpp | 28 ++++++++++++++-------------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/game/packet_parsers_classic.cpp b/src/game/packet_parsers_classic.cpp index 946b9acc..03e0c5a0 100644 --- a/src/game/packet_parsers_classic.cpp +++ b/src/game/packet_parsers_classic.cpp @@ -1012,7 +1012,7 @@ bool ClassicPacketParsers::parseGossipMessage(network::Packet& packet, GossipMes data.quests.push_back(quest); } - LOG_INFO("Classic Gossip: ", optionCount, " options, ", questCount, " quests"); + LOG_DEBUG("Classic Gossip: ", optionCount, " options, ", questCount, " quests"); return true; } @@ -1503,7 +1503,7 @@ bool TurtlePacketParsers::parseMonsterMove(network::Packet& packet, MonsterMoveD packet.setReadPos(start); if (MonsterMoveParser::parse(packet, data)) { - LOG_WARNING("[Turtle] SMSG_MONSTER_MOVE parsed via WotLK fallback layout"); + LOG_DEBUG("[Turtle] SMSG_MONSTER_MOVE parsed via WotLK fallback layout"); return true; } diff --git a/src/game/packet_parsers_tbc.cpp b/src/game/packet_parsers_tbc.cpp index 5232ba33..ffc7d3cd 100644 --- a/src/game/packet_parsers_tbc.cpp +++ b/src/game/packet_parsers_tbc.cpp @@ -484,7 +484,7 @@ bool TbcPacketParsers::parseUpdateObject(network::Packet& packet, UpdateObjectDa packet.setReadPos(startPos); if (parseWithLayout(false, parsed)) { - LOG_WARNING("[TBC] SMSG_UPDATE_OBJECT parsed without has_transport byte fallback"); + LOG_DEBUG("[TBC] SMSG_UPDATE_OBJECT parsed without has_transport byte fallback"); data = std::move(parsed); return true; } @@ -536,7 +536,7 @@ bool TbcPacketParsers::parseGossipMessage(network::Packet& packet, GossipMessage data.quests.push_back(quest); } - LOG_INFO("[TBC] Gossip: ", optionCount, " options, ", questCount, " quests"); + LOG_DEBUG("[TBC] Gossip: ", optionCount, " options, ", questCount, " quests"); return true; } @@ -718,7 +718,7 @@ bool TbcPacketParsers::parseQuestDetails(network::Packet& packet, QuestDetailsDa data.objectives = normalizeWowTextTokens(packet.readString()); if (packet.getReadPos() + 5 > packet.getSize()) { - LOG_INFO("Quest details tbc/classic (short): id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest details tbc/classic (short): id=", data.questId, " title='", data.title, "'"); return !data.title.empty() || data.questId != 0; } @@ -759,7 +759,7 @@ bool TbcPacketParsers::parseQuestDetails(network::Packet& packet, QuestDetailsDa if (packet.getReadPos() + 4 <= packet.getSize()) data.rewardXp = packet.readUInt32(); - LOG_INFO("Quest details tbc/classic: id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest details tbc/classic: id=", data.questId, " title='", data.title, "'"); return true; } @@ -783,7 +783,7 @@ network::Packet TbcPacketParsers::buildQueryQuestPacket(uint64_t npcGuid, uint32 // SMSG_SET_EXTRA_AURA_INFO_OBSOLETE (0x3A4) instead // ============================================================================ bool TbcPacketParsers::parseAuraUpdate(network::Packet& /*packet*/, AuraUpdateData& /*data*/, bool /*isAll*/) { - LOG_WARNING("[TBC] parseAuraUpdate called but SMSG_AURA_UPDATE does not exist in TBC 2.4.3"); + LOG_DEBUG("[TBC] parseAuraUpdate called but SMSG_AURA_UPDATE does not exist in TBC 2.4.3"); return false; } diff --git a/src/game/world_packets.cpp b/src/game/world_packets.cpp index d64c6d49..69427728 100644 --- a/src/game/world_packets.cpp +++ b/src/game/world_packets.cpp @@ -2228,7 +2228,7 @@ bool NameQueryResponseParser::parse(network::Packet& packet, NameQueryResponseDa data.gender = packet.readUInt8(); data.classId = packet.readUInt8(); - LOG_INFO("Name query response: ", data.name, " (race=", (int)data.race, + LOG_DEBUG("Name query response: ", data.name, " (race=", (int)data.race, " class=", (int)data.classId, ")"); return true; } @@ -2718,7 +2718,7 @@ bool AttackStartParser::parse(network::Packet& packet, AttackStartData& data) { if (packet.getSize() < 16) return false; data.attackerGuid = packet.readUInt64(); data.victimGuid = packet.readUInt64(); - LOG_INFO("Attack started: 0x", std::hex, data.attackerGuid, + LOG_DEBUG("Attack started: 0x", std::hex, data.attackerGuid, " -> 0x", data.victimGuid, std::dec); return true; } @@ -2729,7 +2729,7 @@ bool AttackStopParser::parse(network::Packet& packet, AttackStopData& data) { if (packet.getReadPos() < packet.getSize()) { data.unknown = packet.readUInt32(); } - LOG_INFO("Attack stopped: 0x", std::hex, data.attackerGuid, std::dec); + LOG_DEBUG("Attack stopped: 0x", std::hex, data.attackerGuid, std::dec); return true; } @@ -2821,7 +2821,7 @@ bool XpGainParser::parse(network::Packet& packet, XpGainData& data) { data.groupBonus = data.totalXp - static_cast(data.totalXp / groupRate); } } - LOG_INFO("XP gain: ", data.totalXp, " xp (type=", static_cast(data.type), ")"); + LOG_DEBUG("XP gain: ", data.totalXp, " xp (type=", static_cast(data.type), ")"); return data.totalXp > 0; } @@ -3173,7 +3173,7 @@ bool PartyCommandResultParser::parse(network::Packet& packet, PartyCommandResult data.command = static_cast(packet.readUInt32()); data.name = packet.readString(); data.result = static_cast(packet.readUInt32()); - LOG_INFO("Party command result: ", (int)data.result); + LOG_DEBUG("Party command result: ", (int)data.result); return true; } @@ -3320,7 +3320,7 @@ bool LootResponseParser::parse(network::Packet& packet, LootResponseData& data) } } - LOG_INFO("Loot response: ", (int)itemCount, " regular + ", (int)questItemCount, + LOG_DEBUG("Loot response: ", (int)itemCount, " regular + ", (int)questItemCount, " quest items, ", data.gold, " copper"); return true; } @@ -3389,7 +3389,7 @@ bool QuestDetailsParser::parse(network::Packet& packet, QuestDetailsData& data) data.objectives = normalizeWowTextTokens(packet.readString()); if (packet.getReadPos() + 10 > packet.getSize()) { - LOG_INFO("Quest details (short): id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest details (short): id=", data.questId, " title='", data.title, "'"); return true; } @@ -3426,7 +3426,7 @@ bool QuestDetailsParser::parse(network::Packet& packet, QuestDetailsData& data) if (packet.getReadPos() + 4 <= packet.getSize()) data.rewardXp = packet.readUInt32(); - LOG_INFO("Quest details: id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest details: id=", data.questId, " title='", data.title, "'"); return true; } @@ -3463,7 +3463,7 @@ bool GossipMessageParser::parse(network::Packet& packet, GossipMessageData& data data.quests.push_back(quest); } - LOG_INFO("Gossip: ", optionCount, " options, ", questCount, " quests"); + LOG_DEBUG("Gossip: ", optionCount, " options, ", questCount, " quests"); return true; } @@ -3495,7 +3495,7 @@ bool QuestRequestItemsParser::parse(network::Packet& packet, QuestRequestItemsDa data.completionText = normalizeWowTextTokens(packet.readString()); if (packet.getReadPos() + 9 > packet.getSize()) { - LOG_INFO("Quest request items (short): id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest request items (short): id=", data.questId, " title='", data.title, "'"); return true; } @@ -3571,7 +3571,7 @@ bool QuestRequestItemsParser::parse(network::Packet& packet, QuestRequestItemsDa data.completableFlags = chosen->completableFlags; data.requiredItems = chosen->requiredItems; - LOG_INFO("Quest request items: id=", data.questId, " title='", data.title, + LOG_DEBUG("Quest request items: id=", data.questId, " title='", data.title, "' items=", data.requiredItems.size(), " completable=", data.isCompletable()); return true; } @@ -3584,7 +3584,7 @@ bool QuestOfferRewardParser::parse(network::Packet& packet, QuestOfferRewardData data.rewardText = normalizeWowTextTokens(packet.readString()); if (packet.getReadPos() + 10 > packet.getSize()) { - LOG_INFO("Quest offer reward (short): id=", data.questId, " title='", data.title, "'"); + LOG_DEBUG("Quest offer reward (short): id=", data.questId, " title='", data.title, "'"); return true; } @@ -3698,7 +3698,7 @@ bool QuestOfferRewardParser::parse(network::Packet& packet, QuestOfferRewardData data.rewardXp = best->rewardXp; } - LOG_INFO("Quest offer reward: id=", data.questId, " title='", data.title, + LOG_DEBUG("Quest offer reward: id=", data.questId, " title='", data.title, "' choices=", data.choiceRewards.size(), " fixed=", data.fixedRewards.size()); return true; } @@ -3811,7 +3811,7 @@ bool ListInventoryParser::parse(network::Packet& packet, ListInventoryData& data data.items.push_back(item); } - LOG_INFO("Vendor inventory: ", (int)itemCount, " items (extendedCost: ", hasExtendedCost ? "yes" : "no", ")"); + LOG_DEBUG("Vendor inventory: ", (int)itemCount, " items (extendedCost: ", hasExtendedCost ? "yes" : "no", ")"); return true; }