phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 01:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove dead code, name constants, add why-comments

Browse source 
- renderer: remove no-op assignment (mountAnims_.stand = 0 when already 0)
- renderer: add why-comments on blacksmith WMO ID 96048 (ambient forge
  sounds) with TODO for other smithy buildings
- terrain_renderer: replace 1e30f sentinel with numeric_limits::max(),
  name terrain view distance constant (1200 units ≈ 9 ADT tiles)
- social_handler: add missing LFG case 15, document case 0 nullptr
  return (success = no error message), add enum name comments
This commit is contained in:
Kelsi 2026-03-30 14:10:32 -07:00
parent 4acebff65c
commit 6dfac314ee
3 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/game/social_handler.cpp
View file

@ -20,9 +20,12 @@ namespace game {
// LFG join result codes from LFGJoinResult enum (WotLK 3.3.5a).
// Case 0 = success (no error message needed), returns nullptr so the caller
// knows not to display an error string.
static const char* lfgJoinResultString(uint8_t result) {
switch (result) {
case 0: return nullptr;
case 0: return nullptr; // LFG_JOIN_OK
case 1: return "Role check failed.";
case 2: return "No LFG slots available for your group.";
case 3: return "No LFG object found.";
@ -37,6 +40,7 @@ static const char* lfgJoinResultString(uint8_t result) {
case 12: return "A party member is marked as a deserter.";
case 13: return "You are on a random dungeon cooldown.";
case 14: return "A party member is on a random dungeon cooldown.";
case 15: return "Cannot join dungeon finder."; // LFG_JOIN_INTERNAL_ERROR
case 16: return "No spec/role available.";
default: return "Cannot join dungeon finder.";
}