phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: correct SMSG_SPELL_GO REFLECT miss payload size (WotLK/TBC)

Browse source 
WotLK and TBC parsers were reading uint32+uint8 (5 bytes) for
SPELL_MISS_REFLECT entries, but the server only sends uint8
reflectResult (1 byte). This caused a 4-byte misalignment after every
reflected spell, corrupting subsequent miss entries and SpellCastTargets
parsing. Classic parser was already correct.
This commit is contained in:
Kelsi 2026-03-18 06:20:18 -07:00
parent 25138b5648
commit 702155ff4f
2 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/game/packet_parsers_tbc.cpp
View file

@ -1403,15 +1403,14 @@ bool TbcPacketParsers::parseSpellGo(network::Packet& packet, SpellGoData& data)
SpellGoMissEntry m; SpellGoMissEntry m;
m.targetGuid = packet.readUInt64(); // full GUID in TBC m.targetGuid = packet.readUInt64(); // full GUID in TBC
m.missType = packet.readUInt8(); m.missType = packet.readUInt8();
if (m.missType == 11) { if (m.missType == 11) { // SPELL_MISS_REFLECT
if (packet.getReadPos() + 5 > packet.getSize()) { if (packet.getReadPos() + 1 > packet.getSize()) {
LOG_WARNING("[TBC] Spell go: truncated reflect payload at miss index ", i, LOG_WARNING("[TBC] Spell go: truncated reflect payload at miss index ", i,
"/", (int)rawMissCount); "/", (int)rawMissCount);
truncatedTargets = true; truncatedTargets = true;
break; break;
} }
(void)packet.readUInt32(); (void)packet.readUInt8(); // reflectResult
(void)packet.readUInt8();
} }
if (i < storedMissLimit) { if (i < storedMissLimit) {
data.missTargets.push_back(m); data.missTargets.push_back(m);

7
src/game/world_packets.cpp
View file

@ -3912,14 +3912,13 @@ bool SpellGoParser::parse(network::Packet& packet, SpellGoData& data) {
break; break;
} }
m.missType = packet.readUInt8(); m.missType = packet.readUInt8();
if (m.missType == 11) { if (m.missType == 11) { // SPELL_MISS_REFLECT
if (packet.getSize() - packet.getReadPos() < 5) { if (packet.getSize() - packet.getReadPos() < 1) {
LOG_WARNING("Spell go: truncated reflect payload at miss index ", i, "/", (int)rawMissCount); LOG_WARNING("Spell go: truncated reflect payload at miss index ", i, "/", (int)rawMissCount);
truncatedTargets = true; truncatedTargets = true;
break; break;
} }
(void)packet.readUInt32(); (void)packet.readUInt8(); // reflectResult
(void)packet.readUInt8();
} }
if (i < storedMissLimit) { if (i < storedMissLimit) {
data.missTargets.push_back(m); data.missTargets.push_back(m);