phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-24 23:33:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(editor): correct extensions for 6 catalogs in format/list tables
Some checks are pending
Build / Build (arm64) (push) Waiting to run
Details
Build / Build (x86-64) (push) Waiting to run
Details
Build / Build (macOS arm64) (push) Waiting to run
Details
Build / Build (windows-arm64) (push) Waiting to run
Details
Build / Build (windows-x86-64) (push) Waiting to run
Details
Security / CodeQL (C/C++) (push) Waiting to run
Details
Security / Semgrep (push) Waiting to run
Details
Security / Sanitizer Build (ASan/UBSan) (push) Waiting to run
Details

Browse source 
The format magic table (cli_format_table.cpp) and the long-form list
(cli_list_formats.cpp) carried stale extensions for six catalogs that
diverged from what the pipeline actually writes:

  WTRN  .wtrr  -> .wtrn   (--info-wtrr -> --info-wtrn)
  WGSP  .wgoss -> .wgsp   (--info-wgoss -> --info-wgsp)
  WTIT  .wttl  -> .wtit   (--info-wttl -> --info-wtit)
  WSEA  .wevt  -> .wsea   (--info-wevt -> --info-wsea)
  WMOU  .wmnt  -> .wmou   (--info-wmnt -> --info-wmou)
  WPCD  .wcnd  -> .wpcd   (--info-wcnd -> --info-wpcd)

Each pipeline impl appends its real extension in save() — .wtrn /
.wgsp / .wtit / .wsea / .wmou / .wpcd — and the per-format CLI
handlers register --info-wtrn / --info-wgsp / etc.  The two tables
were the only places still pointing at the old names, so:
  --info-magic on a real .wtrn was directing users to --info-wtrr
  --rename-by-magic would have renamed .wtrn -> .wtrr, breaking
    bulk-validate and every other table-driven tool
  --bulk-validate skipped these catalogs entirely because
    deriveValidateFlag built --validate-wtrr / --validate-wcnd / etc.
    which no handler registers

Discovered while running an end-to-end audit across all 146 open
formats — 7 catalogs were unreachable through the magic table.  Audit
now reports 139 ok / 6 skipped (asset formats + engine-loaded) / 1
false-positive (--gen-mesh needs additional args).
This commit is contained in:
Kelsi 2026-05-13 11:13:09 -07:00
parent 11441c8b7c
commit 70efda9b51
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tools/editor/cli_format_table.cpp
View file

@ -25,20 +25,20 @@ constexpr FormatMagicEntry kFormats[] = {
{{'W','M','S','X'}, ".wms", "maps", "--info-wms", "Map / area catalog"},
{{'W','C','H','C'}, ".wchc", "chars", "--info-wchc", "Class + race catalog"},
{{'W','A','C','H'}, ".wach", "achieve", "--info-wach", "Achievement catalog"},
{{'W','T','R','N'}, ".wtrr", "trainers", "--info-wtrr", "Trainer catalog"},
{{'W','G','S','P'}, ".wgoss", "gossip", "--info-wgoss", "Gossip menu catalog"},
{{'W','T','R','N'}, ".wtrn", "trainers", "--info-wtrn", "Trainer catalog"},
{{'W','G','S','P'}, ".wgsp", "gossip", "--info-wgsp", "Gossip menu catalog"},
{{'W','T','A','X'}, ".wtax", "taxi", "--info-wtax", "Taxi node catalog"},
{{'W','T','A','L'}, ".wtal", "talents", "--info-wtal", "Talent catalog"},
{{'W','T','K','N'}, ".wtkn", "tokens", "--info-wtkn", "Token catalog"},
{{'W','T','R','G'}, ".wtrg", "triggers", "--info-wtrg", "Trigger catalog"},
{{'W','T','I','T'}, ".wttl", "titles", "--info-wttl", "Title catalog"},
{{'W','S','E','A'}, ".wevt", "events", "--info-wevt", "Event catalog"},
{{'W','M','O','U'}, ".wmnt", "mounts", "--info-wmnt", "Mount catalog"},
{{'W','T','I','T'}, ".wtit", "titles", "--info-wtit", "Title catalog"},
{{'W','S','E','A'}, ".wsea", "events", "--info-wsea", "Event catalog"},
{{'W','M','O','U'}, ".wmou", "mounts", "--info-wmou", "Mount catalog"},
{{'W','B','G','D'}, ".wbgd", "battle", "--info-wbgd", "Battleground catalog"},
{{'W','M','A','L'}, ".wmal", "mail", "--info-wmal", "Mail catalog"},
{{'W','G','E','M'}, ".wgem", "gems", "--info-wgem", "Gem catalog"},
{{'W','G','L','D'}, ".wgld", "guilds", "--info-wgld", "Guild catalog"},
{{'W','P','C','D'}, ".wcnd", "cond", "--info-wcnd", "Condition catalog"},
{{'W','P','C','D'}, ".wpcd", "cond", "--info-wpcd", "Condition catalog"},
{{'W','P','E','T'}, ".wpet", "pets", "--info-wpet", "Pet catalog"},
{{'W','A','U','C'}, ".wauc", "auction", "--info-wauc", "Auction catalog"},
{{'W','C','H','N'}, ".wchn", "channels", "--info-wchn", "Channel catalog"},