phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: use expansion-aware item size in LootResponseParser for Classic/TBC

Browse source 
The previous per-iteration heuristic (remaining >= 22 → 22 bytes, >= 14 → 14 bytes)
incorrectly parsed Classic/TBC multi-item loots: 2+ items × 14 bytes would
trigger the 22-byte WotLK path for the first item, corrupting subsequent items.

Classic 1.12 and TBC 2.4.3 use 14 bytes/item (slot+itemId+count+displayInfo+slotType).
WotLK 3.3.5a uses 22 bytes/item (adds randomSuffix+randomPropertyId).

Add isWotlkFormat bool parameter to LootResponseParser::parse and pass
isActiveExpansion('wotlk') from handleLootResponse.
This commit is contained in:
Kelsi 2026-03-11 04:01:07 -07:00
parent dd7d74cb93
commit 750b270502
3 changed files with 22 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/game/world_packets.hpp
View file

@ -2015,7 +2015,9 @@ public:
/** SMSG_LOOT_RESPONSE parser */
class LootResponseParser {
public:
static bool parse(network::Packet& packet, LootResponseData& data);
// isWotlkFormat: true for WotLK 3.3.5a (22 bytes/item with randomSuffix+randomProp),
// false for Classic 1.12 and TBC 2.4.3 (14 bytes/item).
static bool parse(network::Packet& packet, LootResponseData& data, bool isWotlkFormat = true);
};
// ============================================================