From 758f7b27b9e4764bda0e9a59350f7c1f36276144 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Sun, 5 Apr 2026 20:58:11 -0700 Subject: [PATCH] fix(logging): downgrade remaining emote registry diagnostics to DEBUG Remove temporary NPC death diagnostic from entity_controller and downgrade emote override/load-count messages from WARNING to DEBUG. --- src/game/entity_controller.cpp | 3 --- src/rendering/animation/emote_registry.cpp | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/game/entity_controller.cpp b/src/game/entity_controller.cpp index 78a95a31..2af369de 100644 --- a/src/game/entity_controller.cpp +++ b/src/game/entity_controller.cpp @@ -754,9 +754,6 @@ EntityController::UnitFieldUpdateResult EntityController::applyUnitFieldsOnUpdat unit->setHealth(val); result.healthChanged = true; if (val == 0) { - LOG_WARNING("NPC death: guid=0x", std::hex, block.guid, std::dec, - " type=", static_cast(entity->getType()), - " hasDeathCb=", (owner_.npcDeathCallbackRef() ? 1 : 0)); if (owner_.getCombatHandler() && block.guid == owner_.getCombatHandler()->getAutoAttackTargetGuid()) { owner_.stopAutoAttack(); } diff --git a/src/rendering/animation/emote_registry.cpp b/src/rendering/animation/emote_registry.cpp index 0d438184..3e743bad 100644 --- a/src/rendering/animation/emote_registry.cpp +++ b/src/rendering/animation/emote_registry.cpp @@ -117,7 +117,7 @@ void EmoteRegistry::loadFromDbc() { uint32_t animId = emotesDbc->getUInt32(r, emL ? (*emL)["AnimID"] : 2); if (animId != 0) emoteIdToAnim[emoteId] = animId; } - LOG_WARNING("Emotes: loaded ", emoteIdToAnim.size(), " anim mappings from Emotes.dbc"); + LOG_DEBUG("Emotes: loaded ", emoteIdToAnim.size(), " anim mappings from Emotes.dbc"); } else { LOG_WARNING("Emotes: Emotes.dbc failed to load — all emotes will use fallback animations"); } @@ -182,17 +182,17 @@ void EmoteRegistry::loadFromDbc() { if (info.animId == 0) { auto ov = kAnimOverrides.find(cmd); if (ov != kAnimOverrides.end()) { - LOG_WARNING("Emotes: override /", cmd, " → animId=", ov->second); + LOG_DEBUG("Emotes: override /", cmd, " → animId=", ov->second); info.animId = ov->second; } } } if (emoteTable_.empty()) { - LOG_WARNING("Emotes: DBC loaded but no commands parsed, using fallback list"); + LOG_DEBUG("Emotes: DBC loaded but no commands parsed, using fallback list"); loadFallbackEmotes(); } else { - LOG_WARNING("Emotes: loaded ", emoteTable_.size(), " commands from DBC"); + LOG_DEBUG("Emotes: loaded ", emoteTable_.size(), " commands from DBC"); } buildDbcIdIndex();