phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-06 17:13:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(wob): warn + clamp uint32 indices on WMO conversion

Browse source 
WoB allows uint32 indices but WMO format is uint16. The previous
static_cast would silently wrap a >65k index into a wrong-but-
valid value — producing visible mis-stitched triangles in the
renderer. Now log a warning once per group and clamp to 0
(degenerate triangle) so the bug is visible.
This commit is contained in:
Kelsi 2026-05-06 07:32:07 -07:00
parent 9d944ed2f9
commit 778f4aca3e
1 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/pipeline/wowee_building.cpp
View file

@ -379,8 +379,22 @@ bool WoweeBuildingLoader::toWMOModel(const WoweeBuilding& building, WMOModel& ou
}
wmoGroup.indices.reserve(grp.indices.size());
for (uint32_t idx : grp.indices)
wmoGroup.indices.push_back(static_cast<uint16_t>(idx));
// WMO format uses uint16 indices, so each group must stay under 65k
// verts. WoB allows uint32 — log + clamp instead of silently
// wrapping and producing garbage triangles in the renderer.
bool warnedTrunc = false;
for (uint32_t idx : grp.indices) {
if (idx > 0xFFFF) {
if (!warnedTrunc) {
LOG_WARNING("toWMOModel: group '", grp.name,
"' has index > 65535 (clamping to 0)");
warnedTrunc = true;
}
wmoGroup.indices.push_back(0);
} else {
wmoGroup.indices.push_back(static_cast<uint16_t>(idx));
}
}
outModel.groups.push_back(std::move(wmoGroup));
}