phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-07 01:23:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(sql): expand string escape to handle NUL, CR/LF/tab, Ctrl-Z

Browse source 
The previous escape only doubled quotes and backslashes. A quest
description containing a literal newline would emit a multi-line
INSERT that breaks per-line execution scripts; a NUL byte could
prematurely terminate the string in non-length-prefixed clients;
Ctrl-Z is the historical MySQL string terminator on Windows.

Now full MySQL/MariaDB string-literal escape: NUL drops, CR/LF/tab
become \r/\n/\t, Ctrl-Z becomes \Z.
This commit is contained in:
Kelsi 2026-05-06 07:22:04 -07:00
parent 19e479a8ff
commit 7a03011625
1 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tools/editor/sql_exporter.cpp
View file

@ -14,9 +14,22 @@ std::string SQLExporter::escape(const std::string& s) {
std::string out;
out.reserve(s.size());
for (char c : s) {
if (c == '\'') out += "''";
else if (c == '\\') out += "\\\\";
else out += c;
// MySQL/MariaDB string-literal escape rules. The backslash sequences
// are the canonical way; doubled single quote works inside single-
// quoted strings either way (matches AzerothCore's import scripts).
// Stripping NUL prevents premature string termination in clients
// that don't fully respect length-prefixed strings; \r/\n keep
// each INSERT on its own line for human-readable export files.
switch (c) {
case '\'': out += "''"; break;
case '\\': out += "\\\\"; break;
case '\0': /* drop NUL */ break;
case '\n': out += "\\n"; break;
case '\r': out += "\\r"; break;
case '\t': out += "\\t"; break;
case 26: out += "\\Z"; break; // Ctrl-Z
default: out += c; break;
}
}
return out;
}