phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: add player name tab-completion in chat input

Browse source 
When typing commands like /w, /whisper, /invite, /trade, /duel, /follow,
/inspect, etc., pressing Tab now cycles through matching player names.

Name sources (in priority order):
1. Last whisper sender (most likely target for /r follow-ups)
2. Party/raid members
3. Friends list
4. Nearby visible players

Tab cycles through all matches; single match auto-appends a space.
Complements the existing slash-command tab-completion.
This commit is contained in:
Kelsi 2026-03-21 03:49:02 -07:00
parent 0d49cc8b94
commit 8229a963d1
2 changed files with 106 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
include/ui/game_screen.hpp
View file

@ -62,7 +62,10 @@ private:
// Populated by the SpellCastFailedCallback; queried during action bar button rendering.
std::unordered_map<uint32_t, float> actionFlashEndTimes_;
// Tab-completion state for slash commands
// Cached game handler for input callbacks (set each frame in render)
game::GameHandler* cachedGameHandler_ = nullptr;
// Tab-completion state for slash commands and player names
std::string chatTabPrefix_; // prefix captured on first Tab press
std::vector<std::string> chatTabMatches_; // matching command list
int chatTabMatchIdx_ = -1; // active match index (-1 = inactive)

102
src/ui/game_screen.cpp
View file

@ -268,6 +268,7 @@ static std::string evaluateMacroConditionals(const std::string& rawArg,
static std::string getMacroShowtooltipArg(const std::string& macroText);
void GameScreen::render(game::GameHandler& gameHandler) {
cachedGameHandler_ = &gameHandler;
// Set up chat bubble callback (once)
if (!chatBubbleCallbackSet_) {
gameHandler.setChatBubbleCallback([this](uint64_t guid, const std::string& msg, bool isYell) {
@ -2674,6 +2675,107 @@ void GameScreen::renderChatWindow(game::GameHandler& gameHandler) {
data->DeleteChars(0, data->BufTextLen);
data->InsertChars(0, newBuf.c_str());
}
} else if (data->BufTextLen > 0) {
// Player name tab-completion for commands like /w, /whisper, /invite, /trade, /duel
// Also works for plain text (completes nearby player names)
std::string fullBuf(data->Buf, data->BufTextLen);
size_t spacePos = fullBuf.find(' ');
bool isNameCommand = false;
std::string namePrefix;
size_t replaceStart = 0;
if (fullBuf[0] == '/' && spacePos != std::string::npos) {
std::string cmd = fullBuf.substr(0, spacePos);
for (char& c : cmd) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
// Commands that take a player name as the first argument after the command
if (cmd == "/w" || cmd == "/whisper" || cmd == "/invite" ||
cmd == "/trade" || cmd == "/duel" || cmd == "/follow" ||
cmd == "/inspect" || cmd == "/friend" || cmd == "/removefriend" ||
cmd == "/ignore" || cmd == "/unignore" || cmd == "/who" ||
cmd == "/t" || cmd == "/target" || cmd == "/kick" ||
cmd == "/uninvite" || cmd == "/ginvite" || cmd == "/gkick") {
// Extract the partial name after the space
namePrefix = fullBuf.substr(spacePos + 1);
// Only complete the first word after the command
size_t nameSpace = namePrefix.find(' ');
if (nameSpace == std::string::npos) {
isNameCommand = true;
replaceStart = spacePos + 1;
}
}
}
if (isNameCommand && !namePrefix.empty()) {
std::string lowerPrefix = namePrefix;
for (char& c : lowerPrefix) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
if (self->chatTabMatchIdx_ < 0 || self->chatTabPrefix_ != lowerPrefix) {
self->chatTabPrefix_ = lowerPrefix;
self->chatTabMatches_.clear();
// Search player name cache and nearby entities
auto* gh = self->cachedGameHandler_;
// Party/raid members
for (const auto& m : gh->getPartyData().members) {
if (m.name.empty()) continue;
std::string lname = m.name;
for (char& c : lname) c = static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
if (lname.compare(0, lowerPrefix.size(), lowerPrefix) == 0)
self->chatTabMatches_.push_back(m.name);
}
// Friends
for (const auto& c : gh->getContacts()) {
if (!c.isFriend() || c.name.empty()) continue;
std::string lname = c.name;
for (char& cc : lname) cc = static_cast<char>(std::tolower(static_cast<unsigned char>(cc)));
if (lname.compare(0, lowerPrefix.size(), lowerPrefix) == 0) {
// Avoid duplicates from party
bool dup = false;
for (const auto& em : self->chatTabMatches_)
if (em == c.name) { dup = true; break; }
if (!dup) self->chatTabMatches_.push_back(c.name);
}
}
// Nearby visible players
for (const auto& [guid, entity] : gh->getEntityManager().getEntities()) {
if (!entity || entity->getType() != game::ObjectType::PLAYER) continue;
auto player = std::static_pointer_cast<game::Player>(entity);
if (player->getName().empty()) continue;
std::string lname = player->getName();
for (char& cc : lname) cc = static_cast<char>(std::tolower(static_cast<unsigned char>(cc)));
if (lname.compare(0, lowerPrefix.size(), lowerPrefix) == 0) {
bool dup = false;
for (const auto& em : self->chatTabMatches_)
if (em == player->getName()) { dup = true; break; }
if (!dup) self->chatTabMatches_.push_back(player->getName());
}
}
// Last whisper sender
if (!gh->getLastWhisperSender().empty()) {
std::string lname = gh->getLastWhisperSender();
for (char& cc : lname) cc = static_cast<char>(std::tolower(static_cast<unsigned char>(cc)));
if (lname.compare(0, lowerPrefix.size(), lowerPrefix) == 0) {
bool dup = false;
for (const auto& em : self->chatTabMatches_)
if (em == gh->getLastWhisperSender()) { dup = true; break; }
if (!dup) self->chatTabMatches_.insert(self->chatTabMatches_.begin(), gh->getLastWhisperSender());
}
}
self->chatTabMatchIdx_ = 0;
} else {
++self->chatTabMatchIdx_;
if (self->chatTabMatchIdx_ >= static_cast<int>(self->chatTabMatches_.size()))
self->chatTabMatchIdx_ = 0;
}
if (!self->chatTabMatches_.empty()) {
std::string match = self->chatTabMatches_[self->chatTabMatchIdx_];
std::string prefix = fullBuf.substr(0, replaceStart);
std::string newBuf = prefix + match;
if (self->chatTabMatches_.size() == 1) newBuf += ' ';
data->DeleteChars(0, data->BufTextLen);
data->InsertChars(0, newBuf.c_str());
}
}
}
return 0;
}