phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-14 16:33:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: doodad/mount animations synchronized due to unseeded rand()

Browse source 
All 8 rand() calls for animation time offsets and variation timers in
m2_renderer.cpp used C rand() which defaults to seed 1 without srand(),
producing identical sequences every launch. Trees, torches, and grass
all swayed in sync. Replaced with std::mt19937 seeded from
random_device. Same fix for 4 mount idle fidget/sound timer sites in
renderer.cpp which mixed rand() with the mt19937 already present.
This commit is contained in:
Kelsi 2026-03-29 20:42:10 -07:00
parent 16aaf58198
commit 849542d01d
2 changed files with 34 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/rendering/renderer.cpp
View file

@ -2118,18 +2118,19 @@ void Renderer::updateCharacterAnimation() {
// Idle fidgets: random one-shot animations when standing still
if (!moving && mountAction_ == MountAction::None && mountActiveFidget_ == 0 && !mountAnims_.fidgets.empty()) {
mountIdleFidgetTimer_ += lastDeltaTime_;
static float nextFidgetTime = 6.0f + (rand() % 7); // 6-12 seconds
// Use the seeded mt19937 for timing so fidgets aren't deterministic
// across launches (rand() without srand() always starts from seed 1).
static std::mt19937 idleRng(std::random_device{}());
static float nextFidgetTime = std::uniform_real_distribution<float>(6.0f, 12.0f)(idleRng);
if (mountIdleFidgetTimer_ >= nextFidgetTime) {
// Trigger random fidget animation
static std::mt19937 rng(std::random_device{}());
std::uniform_int_distribution<size_t> dist(0, mountAnims_.fidgets.size() - 1);
uint32_t fidgetAnim = mountAnims_.fidgets[dist(rng)];
uint32_t fidgetAnim = mountAnims_.fidgets[dist(idleRng)];
characterRenderer->playAnimation(mountInstanceId_, fidgetAnim, false);
mountActiveFidget_ = fidgetAnim; // Track active fidget
mountActiveFidget_ = fidgetAnim;
mountIdleFidgetTimer_ = 0.0f;
nextFidgetTime = 6.0f + (rand() % 7); // Randomize next fidget time
nextFidgetTime = std::uniform_real_distribution<float>(6.0f, 12.0f)(idleRng);
LOG_DEBUG("Mount idle fidget: playing anim ", fidgetAnim);
}
@ -2141,12 +2142,13 @@ void Renderer::updateCharacterAnimation() {
// Idle ambient sounds: snorts and whinnies only, infrequent
if (!moving && mountSoundManager) {
mountIdleSoundTimer_ += lastDeltaTime_;
static float nextIdleSoundTime = 45.0f + (rand() % 46); // 45-90 seconds
static std::mt19937 soundRng(std::random_device{}());
static float nextIdleSoundTime = std::uniform_real_distribution<float>(45.0f, 90.0f)(soundRng);
if (mountIdleSoundTimer_ >= nextIdleSoundTime) {
mountSoundManager->playIdleSound();
mountIdleSoundTimer_ = 0.0f;
nextIdleSoundTime = 45.0f + (rand() % 46); // Randomize next sound time
nextIdleSoundTime = std::uniform_real_distribution<float>(45.0f, 90.0f)(soundRng);
}
} else if (moving) {
mountIdleSoundTimer_ = 0.0f; // Reset timer when moving