phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-07 01:23:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(painter): reject NaN endpoints and zero-length lines in paintAlongPath

Browse source 
Two bugs:
1. NaN start/end produced NaN distances that the chunk-skip check
   (dist > width + 40) treated as 'always within range', so every
   chunk got painted.
2. Zero-length line caused glm::normalize to return NaN; same
   downstream effect.

Compute lineDir manually after the length check so we never hit
the divide-by-zero path.
This commit is contained in:
Kelsi 2026-05-06 07:41:58 -07:00
parent 7e48658ab1
commit 869cee70b1
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tools/editor/texture_painter.cpp
View file

@ -243,11 +243,18 @@ void TexturePainter::autoPaintBySlope(float slopeThreshold, const std::string& s
void TexturePainter::paintAlongPath(const glm::vec3& start, const glm::vec3& end,
float width, const std::string& texturePath) {
if (!terrain_ || texturePath.empty()) return;
if (!std::isfinite(start.x) || !std::isfinite(start.y) ||
!std::isfinite(end.x) || !std::isfinite(end.y) ||
!std::isfinite(width) || width <= 0.0f) return;
uint32_t texId = ensureTextureInList(texturePath);
glm::vec2 lineStart(start.x, start.y);
glm::vec2 lineEnd(end.x, end.y);
glm::vec2 lineDir = glm::normalize(lineEnd - lineStart);
float lineLen = glm::length(lineEnd - lineStart);
// Reject zero-length lines: glm::normalize would produce NaN, then
// every subsequent dist would be NaN and the chunk-skip check would
// pass — painting full strength on every chunk in the tile.
if (lineLen < 1e-4f) return;
glm::vec2 lineDir = (lineEnd - lineStart) / lineLen;
for (int ci = 0; ci < 256; ci++) {
auto& chunk = terrain_->chunks[ci];