phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-25 00:20:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: show quest name in QUESTGIVER_QUEST_FAILED, use playerNameCache for achievements

Browse source 
- SMSG_QUESTGIVER_QUEST_FAILED: look up quest title from questLog_ and
  include it in the failure message (same pattern as QUESTUPDATE_FAILED
  fix from previous session)
- SMSG_ACHIEVEMENT_EARNED: fall back to playerNameCache for non-visible
  players before showing a raw hex GUID in the achievement message
This commit is contained in:
Kelsi 2026-03-13 06:36:04 -07:00
parent b1015abffe
commit 8a81ffa29c
1 changed files with 22 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/game/game_handler.cpp
View file

@ -6579,19 +6579,26 @@ void GameHandler::handlePacket(network::Packet& packet) {
case Opcode::SMSG_QUESTGIVER_QUEST_FAILED: {
// uint32 questId + uint32 reason
if (packet.getSize() - packet.getReadPos() >= 8) {
/*uint32_t questId =*/ packet.readUInt32();
uint32_t questId = packet.readUInt32();
uint32_t reason = packet.readUInt32();
const char* reasonStr = "Unknown reason";
std::string questTitle;
for (const auto& q : questLog_)
if (q.questId == questId && !q.title.empty()) { questTitle = q.title; break; }
const char* reasonStr = nullptr;
switch (reason) {
case 1: reasonStr = "Quest failed: failed conditions"; break;
case 2: reasonStr = "Quest failed: inventory full"; break;
case 3: reasonStr = "Quest failed: too far away"; break;
case 4: reasonStr = "Quest failed: another quest is blocking"; break;
case 5: reasonStr = "Quest failed: wrong time of day"; break;
case 6: reasonStr = "Quest failed: wrong race"; break;
case 7: reasonStr = "Quest failed: wrong class"; break;
case 1: reasonStr = "failed conditions"; break;
case 2: reasonStr = "inventory full"; break;
case 3: reasonStr = "too far away"; break;
case 4: reasonStr = "another quest is blocking"; break;
case 5: reasonStr = "wrong time of day"; break;
case 6: reasonStr = "wrong race"; break;
case 7: reasonStr = "wrong class"; break;
}
addSystemChatMessage(reasonStr);
std::string msg = questTitle.empty() ? "Quest" : ('"' + questTitle + '"');
msg += " failed";
if (reasonStr) msg += std::string(": ") + reasonStr;
msg += '.';
addSystemChatMessage(msg);
}
break;
}
@ -22453,6 +22460,11 @@ void GameHandler::handleAchievementEarned(network::Packet& packet) {
if (auto* unit = dynamic_cast<Unit*>(entity.get())) {
senderName = unit->getName();
}
if (senderName.empty()) {
auto nit = playerNameCache.find(guid);
if (nit != playerNameCache.end())
senderName = nit->second;
}
if (senderName.empty()) {
char tmp[32];
std::snprintf(tmp, sizeof(tmp), "0x%llX",