phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(combatlog): validate packed GUID bounds in spell energize log

Browse source
This commit is contained in:
Kelsi 2026-03-14 14:13:39 -07:00
parent 80d59a80aa
commit 90bc9118f9
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/game/game_handler.cpp
View file

@ -4126,11 +4126,13 @@ void GameHandler::handlePacket(network::Packet& packet) {
return (packet.getSize() - packet.getReadPos() >= 8) ? packet.readUInt64() : 0; return (packet.getSize() - packet.getReadPos() >= 8) ? packet.readUInt64() : 0;
return UpdateObjectParser::readPackedGuid(packet); return UpdateObjectParser::readPackedGuid(packet);
}; };
if (packet.getSize() - packet.getReadPos() < (energizeTbc ? 8u : 1u)) { if (packet.getSize() - packet.getReadPos() < (energizeTbc ? 8u : 1u)
|| (!energizeTbc && !hasFullPackedGuid(packet))) {
packet.setReadPos(packet.getSize()); break; packet.setReadPos(packet.getSize()); break;
} }
uint64_t victimGuid = readEnergizeGuid(); uint64_t victimGuid = readEnergizeGuid();
if (packet.getSize() - packet.getReadPos() < (energizeTbc ? 8u : 1u)) { if (packet.getSize() - packet.getReadPos() < (energizeTbc ? 8u : 1u)
|| (!energizeTbc && !hasFullPackedGuid(packet))) {
packet.setReadPos(packet.getSize()); break; packet.setReadPos(packet.getSize()); break;
} }
uint64_t casterGuid = readEnergizeGuid(); uint64_t casterGuid = readEnergizeGuid();