phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: add confirmation dialog before spending talent points

Browse source 
Clicking a learnable talent now opens a modal confirmation popup
showing the spell name and rank, preventing accidental talent spending.
This commit is contained in:
Kelsi 2026-03-18 11:23:35 -07:00
parent ef4cf461a5
commit 9368c8a715
2 changed files with 37 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
include/ui/talent_screen.hpp
View file

@ -45,6 +45,12 @@ private:
std::unordered_map<uint32_t, std::string> spellTooltips; // spellId -> description std::unordered_map<uint32_t, std::string> spellTooltips; // spellId -> description
std::unordered_map<uint32_t, VkDescriptorSet> bgTextureCache_; // tabId -> bg texture std::unordered_map<uint32_t, VkDescriptorSet> bgTextureCache_; // tabId -> bg texture
// Talent learn confirmation
bool talentConfirmOpen_ = false;
uint32_t pendingTalentId_ = 0;
uint32_t pendingTalentRank_ = 0;
std::string pendingTalentName_;
// GlyphProperties.dbc cache: glyphId -> { spellId, isMajor } // GlyphProperties.dbc cache: glyphId -> { spellId, isMajor }
struct GlyphInfo { uint32_t spellId = 0; bool isMajor = false; }; struct GlyphInfo { uint32_t spellId = 0; bool isMajor = false; };
std::unordered_map<uint32_t, GlyphInfo> glyphProperties_; // glyphId -> info std::unordered_map<uint32_t, GlyphInfo> glyphProperties_; // glyphId -> info

34
src/ui/talent_screen.cpp
View file

@ -176,6 +176,29 @@ void TalentScreen::renderTalentTrees(game::GameHandler& gameHandler) {
ImGui::EndTabBar(); ImGui::EndTabBar();
} }
// Talent learn confirmation popup
if (talentConfirmOpen_) {
ImGui::OpenPopup("Learn Talent?##talent_confirm");
talentConfirmOpen_ = false;
}
if (ImGui::BeginPopupModal("Learn Talent?##talent_confirm", nullptr,
ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoMove)) {
ImGui::TextColored(ImVec4(1.0f, 1.0f, 0.3f, 1.0f), "%s", pendingTalentName_.c_str());
ImGui::Text("Rank %u", pendingTalentRank_ + 1);
ImGui::Spacing();
ImGui::TextWrapped("Spend a talent point?");
ImGui::Spacing();
if (ImGui::Button("Learn", ImVec2(80, 0))) {
gameHandler.learnTalent(pendingTalentId_, pendingTalentRank_);
ImGui::CloseCurrentPopup();
}
ImGui::SameLine();
if (ImGui::Button("Cancel", ImVec2(80, 0))) {
ImGui::CloseCurrentPopup();
}
ImGui::EndPopup();
}
} }
void TalentScreen::renderTalentTree(game::GameHandler& gameHandler, uint32_t tabId, void TalentScreen::renderTalentTree(game::GameHandler& gameHandler, uint32_t tabId,
@ -574,10 +597,15 @@ void TalentScreen::renderTalent(game::GameHandler& gameHandler,
ImGui::EndTooltip(); ImGui::EndTooltip();
} }
// Handle click — currentRank is 1-indexed (0=not learned, 1=rank1, ...) // Handle click — open confirmation dialog instead of learning directly
// CMSG_LEARN_TALENT requestedRank must equal current count of learned ranks (same value)
if (clicked && canLearn && prereqsMet) { if (clicked && canLearn && prereqsMet) {
gameHandler.learnTalent(talent.talentId, currentRank); talentConfirmOpen_ = true;
pendingTalentId_ = talent.talentId;
pendingTalentRank_ = currentRank;
uint32_t nextSpell = (currentRank < 5) ? talent.rankSpells[currentRank] : 0;
pendingTalentName_ = nextSpell ? gameHandler.getSpellName(nextSpell) : "";
if (pendingTalentName_.empty())
pendingTalentName_ = spellId ? gameHandler.getSpellName(spellId) : "Talent";
} }
ImGui::PopID(); ImGui::PopID();