phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-24 00:00:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 41

Allow texture load retries instead of permanently caching failures

Browse source 
Remove negative cache for transient load failures in M2, terrain, and
character renderers. Failed textures return white and will be retried
on next model/tile load when assets may have finished streaming.
This commit is contained in:
Kelsi 2026-02-23 06:51:06 -08:00
parent 3e6de8485b
commit 93f873b521
4 changed files with 11 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/rendering/character_renderer.cpp
View file

@ -526,17 +526,12 @@ VkTexture* CharacterRenderer::loadTexture(const std::string& path) {
return whiteTexture_.get();
}
// Check negative cache to avoid repeated file I/O for textures that don't exist
if (failedTextureCache_.count(key)) {
return whiteTexture_.get();
}
auto blpImage = assetManager->loadTexture(key);
if (!blpImage.isValid()) {
static constexpr size_t kMaxFailedTextureCache = 200000;
core::Logger::getInstance().warning("Failed to load texture: ", path);
if (failedTextureCache_.size() < kMaxFailedTextureCache) {
failedTextureCache_.insert(key);
// Return white fallback but don't cache the failure — allow retry
// on next character load in case the asset becomes available.
if (loggedTextureLoadFails_.insert(key).second) {
core::Logger::getInstance().warning("Failed to load texture: ", path);
}
return whiteTexture_.get();
}