phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-16 09:13:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor: extract guidToUnitId/getQuestTitle helpers and misc cleanup

Browse source 
- Extract guidToUnitId(), getQuestTitle(), findQuestLogEntry() helpers
  to replace 14 duplicated GUID-to-unitId patterns and 7 quest log
  search patterns in game_handler.cpp
- Remove duplicate #include in renderer.cpp
- Remove commented-out model cleanup code in terrain_manager.cpp
- Replace C-style casts with static_cast in auth and transport code
This commit is contained in:
Kelsi 2026-03-25 11:25:44 -07:00
parent 087e42d7a1
commit 98b9e502c5
7 changed files with 57 additions and 124 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/auth/auth_packets.cpp
View file

@ -418,14 +418,14 @@ bool RealmListResponseParser::parse(network::Packet& packet, RealmListResponse&
realm.patchVersion = packet.readUInt8();
realm.build = packet.readUInt16();
LOG_DEBUG(" Realm ", (int)i, " (", realm.name, ") version: ",
(int)realm.majorVersion, ".", (int)realm.minorVersion, ".",
(int)realm.patchVersion, " (", realm.build, ")");
LOG_DEBUG(" Realm ", static_cast<int>(i), " (", realm.name, ") version: ",
static_cast<int>(realm.majorVersion), ".", static_cast<int>(realm.minorVersion), ".",
static_cast<int>(realm.patchVersion), " (", realm.build, ")");
} else {
LOG_DEBUG(" Realm ", (int)i, " (", realm.name, ") - no version info");
LOG_DEBUG(" Realm ", static_cast<int>(i), " (", realm.name, ") - no version info");
}
LOG_DEBUG(" Realm ", (int)i, " details:");
LOG_DEBUG(" Realm ", static_cast<int>(i), " details:");
LOG_DEBUG(" Name: ", realm.name);
LOG_DEBUG(" Address: ", realm.address);
LOG_DEBUG(" ID: ", (int)realm.id);