phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: normalize Classic UNIT_FIELD_AURAFLAGS harmful bit to WotLK debuff convention

Browse source 
The buff/debuff bar uses 0x80 (WotLK convention) to identify debuffs.
Classic UNIT_FIELD_AURAFLAGS uses 0x02 for harmful auras instead.
Map Classic 0x02 → 0x80 during aura rebuild so the UI correctly
separates buffs from debuffs for Classic players.
This commit is contained in:
Kelsi 2026-03-12 21:34:16 -07:00
parent 18d0e6a252
commit 9b092782c9
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/game/game_handler.cpp
View file

@ -9011,13 +9011,16 @@ void GameHandler::handleUpdateObject(network::Packet& packet) {
AuraSlot& a = playerAuras[slot];
a.spellId = it->second;
// Read aura flag byte: packed 4-per-uint32 at ufAuraFlags
uint8_t aFlag = 0;
// Classic flags: 0x01=cancelable, 0x02=harmful, 0x04=helpful
// Normalize to WotLK convention: 0x80 = negative (debuff)
uint8_t classicFlag = 0;
if (ufAuraFlags != 0xFFFF) {
auto fit = allFields.find(static_cast<uint16_t>(ufAuraFlags + slot / 4));
if (fit != allFields.end())
aFlag = static_cast<uint8_t>((fit->second >> ((slot % 4) * 8)) & 0xFF);
classicFlag = static_cast<uint8_t>((fit->second >> ((slot % 4) * 8)) & 0xFF);
}
a.flags = aFlag;
// Map Classic harmful bit (0x02) → WotLK debuff bit (0x80)
a.flags = (classicFlag & 0x02) ? 0x80u : 0u;
a.durationMs = -1;
a.maxDurationMs = -1;
a.casterGuid = playerGuid;