From 9b6731d3cef07c2432f080c3c040834da27ba137 Mon Sep 17 00:00:00 2001 From: Kelsi Date: Fri, 20 Feb 2026 00:32:32 -0800 Subject: [PATCH] Fix 17 incorrect WotLK opcode values against AzerothCore reference --- Data/expansions/wotlk/opcodes.json | 34 +++++++++++++++--------------- src/game/opcode_table.cpp | 26 +++++++++++------------ 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/Data/expansions/wotlk/opcodes.json b/Data/expansions/wotlk/opcodes.json index a37c38f9..d5a02f68 100644 --- a/Data/expansions/wotlk/opcodes.json +++ b/Data/expansions/wotlk/opcodes.json @@ -34,7 +34,7 @@ "CMSG_WARDEN_DATA": "0x2E7", "SMSG_ACCOUNT_DATA_TIMES": "0x209", "SMSG_CLIENTCACHE_VERSION": "0x4AB", - "SMSG_FEATURE_SYSTEM_STATUS": "0x3ED", + "SMSG_FEATURE_SYSTEM_STATUS": "0x3C9", "SMSG_MOTD": "0x33D", "SMSG_UPDATE_OBJECT": "0x0A9", "SMSG_COMPRESSED_UPDATE_OBJECT": "0x1F6", @@ -74,8 +74,8 @@ "CMSG_GUILD_MOTD": "0x091", "SMSG_GUILD_INFO": "0x088", "SMSG_GUILD_ROSTER": "0x08A", - "CMSG_GUILD_QUERY": "0x051", - "SMSG_GUILD_QUERY_RESPONSE": "0x052", + "CMSG_GUILD_QUERY": "0x054", + "SMSG_GUILD_QUERY_RESPONSE": "0x055", "SMSG_GUILD_INVITE": "0x083", "CMSG_GUILD_REMOVE": "0x08E", "SMSG_GUILD_EVENT": "0x092", @@ -106,7 +106,7 @@ "SMSG_ATTACKERSTATEUPDATE": "0x14A", "SMSG_SPELLNONMELEEDAMAGELOG": "0x250", "SMSG_SPELLHEALLOG": "0x150", - "SMSG_SPELLENERGIZELOG": "0x25B", + "SMSG_SPELLENERGIZELOG": "0x151", "SMSG_PERIODICAURALOG": "0x24E", "SMSG_ENVIRONMENTALDAMAGELOG": "0x1FC", "CMSG_CAST_SPELL": "0x12E", @@ -123,15 +123,15 @@ "SMSG_LEARNED_SPELL": "0x12B", "SMSG_SUPERCEDED_SPELL": "0x12C", "SMSG_REMOVED_SPELL": "0x203", - "SMSG_SEND_UNLEARN_SPELLS": "0x41F", + "SMSG_SEND_UNLEARN_SPELLS": "0x41E", "SMSG_SPELL_DELAYED": "0x1E2", - "SMSG_AURA_UPDATE": "0x3FA", + "SMSG_AURA_UPDATE": "0x496", "SMSG_AURA_UPDATE_ALL": "0x495", "SMSG_SET_FLAT_SPELL_MODIFIER": "0x266", "SMSG_SET_PCT_SPELL_MODIFIER": "0x267", "SMSG_TALENTS_INFO": "0x4C0", "CMSG_LEARN_TALENT": "0x251", - "MSG_TALENT_WIPE_CONFIRM": "0x2AB", + "MSG_TALENT_WIPE_CONFIRM": "0x2AA", "CMSG_GROUP_INVITE": "0x06E", "SMSG_GROUP_INVITE": "0x06F", "CMSG_GROUP_ACCEPT": "0x072", @@ -143,7 +143,7 @@ "SMSG_GROUP_SET_LEADER": "0x079", "CMSG_GROUP_DISBAND": "0x07B", "SMSG_GROUP_LIST": "0x07D", - "SMSG_PARTY_COMMAND_RESULT": "0x07E", + "SMSG_PARTY_COMMAND_RESULT": "0x07F", "MSG_RAID_TARGET_UPDATE": "0x321", "CMSG_REQUEST_RAID_INFO": "0x2CD", "SMSG_RAID_INSTANCE_INFO": "0x2CC", @@ -156,7 +156,7 @@ "SMSG_LOOT_REMOVED": "0x162", "SMSG_LOOT_MONEY_NOTIFY": "0x163", "SMSG_LOOT_CLEAR_MONEY": "0x165", - "CMSG_ACTIVATETAXI": "0x19D", + "CMSG_ACTIVATETAXI": "0x1AD", "CMSG_GOSSIP_HELLO": "0x17B", "CMSG_GOSSIP_SELECT_OPTION": "0x17C", "SMSG_GOSSIP_MESSAGE": "0x17D", @@ -165,7 +165,7 @@ "CMSG_GAMEOBJECT_USE": "0x0B1", "CMSG_QUESTGIVER_STATUS_QUERY": "0x182", "SMSG_QUESTGIVER_STATUS": "0x183", - "SMSG_QUESTGIVER_STATUS_MULTIPLE": "0x198", + "SMSG_QUESTGIVER_STATUS_MULTIPLE": "0x418", "CMSG_QUESTGIVER_HELLO": "0x184", "CMSG_QUESTGIVER_QUERY_QUEST": "0x186", "SMSG_QUESTGIVER_QUEST_DETAILS": "0x188", @@ -178,11 +178,11 @@ "SMSG_QUESTGIVER_QUEST_INVALID": "0x18F", "SMSG_QUESTGIVER_QUEST_COMPLETE": "0x191", "CMSG_QUESTLOG_REMOVE_QUEST": "0x194", - "SMSG_QUESTUPDATE_ADD_KILL": "0x196", - "SMSG_QUESTUPDATE_COMPLETE": "0x195", + "SMSG_QUESTUPDATE_ADD_KILL": "0x199", + "SMSG_QUESTUPDATE_COMPLETE": "0x198", "CMSG_QUEST_QUERY": "0x05C", "SMSG_QUEST_QUERY_RESPONSE": "0x05D", - "SMSG_QUESTLOG_FULL": "0x1A3", + "SMSG_QUESTLOG_FULL": "0x195", "CMSG_LIST_INVENTORY": "0x19E", "SMSG_LIST_INVENTORY": "0x19F", "CMSG_SELL_ITEM": "0x1A0", @@ -270,15 +270,15 @@ "CMSG_CHANNEL_LIST": "0x09A", "SMSG_CHANNEL_LIST": "0x09B", "SMSG_INSPECT_TALENT": "0x3F4", - "SMSG_SHOW_MAILBOX": "0x24B", + "SMSG_SHOW_MAILBOX": "0x297", "CMSG_GET_MAIL_LIST": "0x23A", "SMSG_MAIL_LIST_RESULT": "0x23B", "CMSG_SEND_MAIL": "0x238", "SMSG_SEND_MAIL_RESULT": "0x239", "CMSG_MAIL_TAKE_MONEY": "0x245", - "CMSG_MAIL_TAKE_ITEM": "0x244", - "CMSG_MAIL_DELETE": "0x243", - "CMSG_MAIL_MARK_AS_READ": "0x242", + "CMSG_MAIL_TAKE_ITEM": "0x246", + "CMSG_MAIL_DELETE": "0x249", + "CMSG_MAIL_MARK_AS_READ": "0x247", "SMSG_RECEIVED_MAIL": "0x285", "MSG_QUERY_NEXT_MAIL_TIME": "0x284" } diff --git a/src/game/opcode_table.cpp b/src/game/opcode_table.cpp index e0e680ed..77f9fb30 100644 --- a/src/game/opcode_table.cpp +++ b/src/game/opcode_table.cpp @@ -425,7 +425,7 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::CMSG_WARDEN_DATA, 0x2E7}, {LogicalOpcode::SMSG_ACCOUNT_DATA_TIMES, 0x209}, {LogicalOpcode::SMSG_CLIENTCACHE_VERSION, 0x4AB}, - {LogicalOpcode::SMSG_FEATURE_SYSTEM_STATUS, 0x3ED}, + {LogicalOpcode::SMSG_FEATURE_SYSTEM_STATUS, 0x3C9}, {LogicalOpcode::SMSG_MOTD, 0x33D}, {LogicalOpcode::SMSG_UPDATE_OBJECT, 0x0A9}, {LogicalOpcode::SMSG_COMPRESSED_UPDATE_OBJECT, 0x1F6}, @@ -471,8 +471,8 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::CMSG_GUILD_MOTD, 0x091}, {LogicalOpcode::SMSG_GUILD_INFO, 0x088}, {LogicalOpcode::SMSG_GUILD_ROSTER, 0x08A}, - {LogicalOpcode::CMSG_GUILD_QUERY, 0x051}, - {LogicalOpcode::SMSG_GUILD_QUERY_RESPONSE, 0x052}, + {LogicalOpcode::CMSG_GUILD_QUERY, 0x054}, + {LogicalOpcode::SMSG_GUILD_QUERY_RESPONSE, 0x055}, {LogicalOpcode::SMSG_GUILD_INVITE, 0x083}, {LogicalOpcode::CMSG_GUILD_REMOVE, 0x08E}, {LogicalOpcode::CMSG_GUILD_DISBAND, 0x08F}, @@ -509,7 +509,7 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::SMSG_SPELLNONMELEEDAMAGELOG, 0x250}, {LogicalOpcode::SMSG_PLAY_SPELL_VISUAL, 0x1F3}, {LogicalOpcode::SMSG_SPELLHEALLOG, 0x150}, - {LogicalOpcode::SMSG_SPELLENERGIZELOG, 0x25B}, + {LogicalOpcode::SMSG_SPELLENERGIZELOG, 0x151}, {LogicalOpcode::SMSG_PERIODICAURALOG, 0x24E}, {LogicalOpcode::SMSG_ENVIRONMENTALDAMAGELOG, 0x1FC}, {LogicalOpcode::CMSG_CAST_SPELL, 0x12E}, @@ -526,16 +526,16 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::SMSG_LEARNED_SPELL, 0x12B}, {LogicalOpcode::SMSG_SUPERCEDED_SPELL, 0x12C}, {LogicalOpcode::SMSG_REMOVED_SPELL, 0x203}, - {LogicalOpcode::SMSG_SEND_UNLEARN_SPELLS, 0x41F}, + {LogicalOpcode::SMSG_SEND_UNLEARN_SPELLS, 0x41E}, {LogicalOpcode::SMSG_SPELL_DELAYED, 0x1E2}, {LogicalOpcode::SMSG_CANCEL_AUTO_REPEAT, 0x06B}, - {LogicalOpcode::SMSG_AURA_UPDATE, 0x3FA}, + {LogicalOpcode::SMSG_AURA_UPDATE, 0x496}, {LogicalOpcode::SMSG_AURA_UPDATE_ALL, 0x495}, {LogicalOpcode::SMSG_SET_FLAT_SPELL_MODIFIER, 0x266}, {LogicalOpcode::SMSG_SET_PCT_SPELL_MODIFIER, 0x267}, {LogicalOpcode::SMSG_TALENTS_INFO, 0x4C0}, {LogicalOpcode::CMSG_LEARN_TALENT, 0x251}, - {LogicalOpcode::MSG_TALENT_WIPE_CONFIRM, 0x2AB}, + {LogicalOpcode::MSG_TALENT_WIPE_CONFIRM, 0x2AA}, {LogicalOpcode::CMSG_GROUP_INVITE, 0x06E}, {LogicalOpcode::SMSG_GROUP_INVITE, 0x06F}, {LogicalOpcode::CMSG_GROUP_ACCEPT, 0x072}, @@ -547,7 +547,7 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::SMSG_GROUP_SET_LEADER, 0x079}, {LogicalOpcode::CMSG_GROUP_DISBAND, 0x07B}, {LogicalOpcode::SMSG_GROUP_LIST, 0x07D}, - {LogicalOpcode::SMSG_PARTY_COMMAND_RESULT, 0x07E}, + {LogicalOpcode::SMSG_PARTY_COMMAND_RESULT, 0x07F}, {LogicalOpcode::MSG_RAID_TARGET_UPDATE, 0x321}, {LogicalOpcode::CMSG_REQUEST_RAID_INFO, 0x2CD}, {LogicalOpcode::SMSG_RAID_INSTANCE_INFO, 0x2CC}, @@ -560,7 +560,7 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::SMSG_LOOT_REMOVED, 0x162}, {LogicalOpcode::SMSG_LOOT_MONEY_NOTIFY, 0x163}, {LogicalOpcode::SMSG_LOOT_CLEAR_MONEY, 0x165}, - {LogicalOpcode::CMSG_ACTIVATETAXI, 0x19D}, + {LogicalOpcode::CMSG_ACTIVATETAXI, 0x1AD}, {LogicalOpcode::CMSG_GOSSIP_HELLO, 0x17B}, {LogicalOpcode::CMSG_GOSSIP_SELECT_OPTION, 0x17C}, {LogicalOpcode::SMSG_GOSSIP_MESSAGE, 0x17D}, @@ -569,7 +569,7 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::CMSG_GAMEOBJECT_USE, 0x0B1}, {LogicalOpcode::CMSG_QUESTGIVER_STATUS_QUERY, 0x182}, {LogicalOpcode::SMSG_QUESTGIVER_STATUS, 0x183}, - {LogicalOpcode::SMSG_QUESTGIVER_STATUS_MULTIPLE, 0x198}, + {LogicalOpcode::SMSG_QUESTGIVER_STATUS_MULTIPLE, 0x418}, {LogicalOpcode::CMSG_QUESTGIVER_HELLO, 0x184}, {LogicalOpcode::SMSG_QUESTGIVER_QUEST_LIST, 0x185}, {LogicalOpcode::CMSG_QUESTGIVER_QUERY_QUEST, 0x186}, @@ -583,13 +583,13 @@ void OpcodeTable::loadWotlkDefaults() { {LogicalOpcode::SMSG_QUESTGIVER_QUEST_INVALID, 0x18F}, {LogicalOpcode::SMSG_QUESTGIVER_QUEST_COMPLETE, 0x191}, {LogicalOpcode::CMSG_QUESTLOG_REMOVE_QUEST, 0x194}, - {LogicalOpcode::SMSG_QUESTUPDATE_ADD_KILL, 0x196}, + {LogicalOpcode::SMSG_QUESTUPDATE_ADD_KILL, 0x199}, {LogicalOpcode::SMSG_QUESTUPDATE_ADD_ITEM, 0x197}, - {LogicalOpcode::SMSG_QUESTUPDATE_COMPLETE, 0x195}, + {LogicalOpcode::SMSG_QUESTUPDATE_COMPLETE, 0x198}, {LogicalOpcode::SMSG_QUEST_FORCE_REMOVE, 0x21E}, {LogicalOpcode::CMSG_QUEST_QUERY, 0x05C}, {LogicalOpcode::SMSG_QUEST_QUERY_RESPONSE, 0x05D}, - {LogicalOpcode::SMSG_QUESTLOG_FULL, 0x1A3}, + {LogicalOpcode::SMSG_QUESTLOG_FULL, 0x195}, {LogicalOpcode::CMSG_LIST_INVENTORY, 0x19E}, {LogicalOpcode::SMSG_LIST_INVENTORY, 0x19F}, {LogicalOpcode::CMSG_SELL_ITEM, 0x1A0},