phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix SMSG_SPELL_DELAYED/EQUIPMENT_SET_SAVED incorrectly sharing PERIODICAURALOG handler

Browse source 
These two opcodes were accidentally falling through to the PERIODICAURALOG
handler which expects packed_guid+packed_guid+uint32+uint32 — wrong format.
Now:
- SMSG_SPELL_DELAYED: parse caster guid + delayMs, extend castTimeRemaining
  on player cast pushback (spell cast bar stays accurate under pushback)
- SMSG_EQUIPMENT_SET_SAVED: simple acknowledge log (no payload needed)
This commit is contained in:
Kelsi 2026-03-09 19:46:52 -07:00
parent 1d33ebbfe4
commit 9f340ef456
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/game/game_handler.cpp
View file

@ -3028,8 +3028,22 @@ void GameHandler::handlePacket(network::Packet& packet) {
case Opcode::SMSG_FEATURE_SYSTEM_STATUS:
case Opcode::SMSG_SET_FLAT_SPELL_MODIFIER:
case Opcode::SMSG_SET_PCT_SPELL_MODIFIER:
case Opcode::SMSG_SPELL_DELAYED:
case Opcode::SMSG_SPELL_DELAYED: {
// packed_guid (caster) + uint32 delayMs — spell cast was pushed back
// Adjust cast bar if it's the player's spell
if (casting && packet.getSize() - packet.getReadPos() >= 1) {
uint64_t caster = UpdateObjectParser::readPackedGuid(packet);
if (caster == playerGuid && packet.getSize() - packet.getReadPos() >= 4) {
uint32_t delayMs = packet.readUInt32();
castTimeRemaining += delayMs / 1000.0f; // Extend cast bar by delay
}
}
break;
}
case Opcode::SMSG_EQUIPMENT_SET_SAVED:
// uint32 setIndex + uint64 guid — equipment set was successfully saved
LOG_DEBUG("Equipment set saved");
break;
case Opcode::SMSG_PERIODICAURALOG: {
// packed_guid victim, packed_guid caster, uint32 spellId, uint32 count, then per-effect
if (packet.getSize() - packet.getReadPos() < 2) break;