phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: show random suffix names in auction outbid and expired notifications

Browse source 
Apply getRandomPropertyName() to SMSG_AUCTION_BIDDER_NOTIFICATION and
SMSG_AUCTION_REMOVED_NOTIFICATION so outbid/expired messages show full
item names like "You have been outbid on Leggings of the Eagle" instead
of just "Leggings". Completes suffix name resolution across all AH contexts.
This commit is contained in:
Kelsi 2026-03-20 20:57:23 -07:00
parent df55242c50
commit 9f49f543f6
1 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/game/game_handler.cpp
View file

@ -6228,14 +6228,21 @@ void GameHandler::handlePacket(network::Packet& packet) {
break; break;
} }
case Opcode::SMSG_AUCTION_BIDDER_NOTIFICATION: { case Opcode::SMSG_AUCTION_BIDDER_NOTIFICATION: {
// auctionId(u32) + itemEntry(u32) + ... // auctionHouseId(u32) + auctionId(u32) + bidderGuid(u64) + bidAmount(u32) + outbidAmount(u32) + itemEntry(u32) + randomPropertyId(u32)
if (packet.getSize() - packet.getReadPos() >= 8) { if (packet.getSize() - packet.getReadPos() >= 8) {
uint32_t auctionId = packet.readUInt32(); /*uint32_t auctionId =*/ packet.readUInt32();
uint32_t itemEntry = packet.readUInt32(); uint32_t itemEntry = packet.readUInt32();
(void)auctionId; int32_t bidRandProp = 0;
// Try to read randomPropertyId if enough data remains
if (packet.getSize() - packet.getReadPos() >= 4)
bidRandProp = static_cast<int32_t>(packet.readUInt32());
ensureItemInfo(itemEntry); ensureItemInfo(itemEntry);
auto* info = getItemInfo(itemEntry); auto* info = getItemInfo(itemEntry);
std::string rawName2 = info && !info->name.empty() ? info->name : ("Item #" + std::to_string(itemEntry)); std::string rawName2 = info && !info->name.empty() ? info->name : ("Item #" + std::to_string(itemEntry));
if (bidRandProp != 0) {
std::string suffix = getRandomPropertyName(bidRandProp);
if (!suffix.empty()) rawName2 += " " + suffix;
}
uint32_t bidQuality = info ? info->quality : 1u; uint32_t bidQuality = info ? info->quality : 1u;
std::string bidLink = buildItemLink(itemEntry, bidQuality, rawName2); std::string bidLink = buildItemLink(itemEntry, bidQuality, rawName2);
addSystemChatMessage("You have been outbid on " + bidLink + "."); addSystemChatMessage("You have been outbid on " + bidLink + ".");
@ -6248,10 +6255,14 @@ void GameHandler::handlePacket(network::Packet& packet) {
if (packet.getSize() - packet.getReadPos() >= 12) { if (packet.getSize() - packet.getReadPos() >= 12) {
/*uint32_t auctionId =*/ packet.readUInt32(); /*uint32_t auctionId =*/ packet.readUInt32();
uint32_t itemEntry = packet.readUInt32(); uint32_t itemEntry = packet.readUInt32();
/*uint32_t itemRandom =*/ packet.readUInt32(); int32_t itemRandom = static_cast<int32_t>(packet.readUInt32());
ensureItemInfo(itemEntry); ensureItemInfo(itemEntry);
auto* info = getItemInfo(itemEntry); auto* info = getItemInfo(itemEntry);
std::string rawName3 = info && !info->name.empty() ? info->name : ("Item #" + std::to_string(itemEntry)); std::string rawName3 = info && !info->name.empty() ? info->name : ("Item #" + std::to_string(itemEntry));
if (itemRandom != 0) {
std::string suffix = getRandomPropertyName(itemRandom);
if (!suffix.empty()) rawName3 += " " + suffix;
}
uint32_t remQuality = info ? info->quality : 1u; uint32_t remQuality = info ? info->quality : 1u;
std::string remLink = buildItemLink(itemEntry, remQuality, rawName3); std::string remLink = buildItemLink(itemEntry, remQuality, rawName3);
addSystemChatMessage("Your auction of " + remLink + " has expired."); addSystemChatMessage("Your auction of " + remLink + " has expired.");