From a0876bbe3dde27c77f95971a2ed3ed5ae3b5d9fb Mon Sep 17 00:00:00 2001
From: Kelsi <kelsihates2fa@gmail.com>
Date: Wed, 6 May 2026 08:08:05 -0700
Subject: [PATCH] fix(cli): error on non-GUI options that are missing their
 argument

Previously '--info-wcp' (no path) silently dropped into the GUI
because the option-parse loop's i+1<argc guard hid the typo. Pre-
scan and bail out with a helpful message before trying to start
the editor, so users get fast feedback on bad invocations.
---
 tools/editor/main.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tools/editor/main.cpp b/tools/editor/main.cpp
index f802be4a..0d3d3953 100644
--- a/tools/editor/main.cpp
+++ b/tools/editor/main.cpp
@@ -45,6 +45,27 @@ int main(int argc, char* argv[]) {
     std::string adtMap;
     int adtX = -1, adtY = -1;
 
+    // Detect non-GUI options that are missing their argument and bail out
+    // with a helpful message instead of silently dropping into the GUI.
+    static const char* kArgRequired[] = {
+        "--data", "--info", "--info-wob", "--info-woc", "--info-wot",
+        "--info-creatures", "--info-objects", "--info-quests",
+        "--info-wcp", "--list-wcp", "--validate",
+        "--convert-m2", "--convert-wmo",
+    };
+    for (int i = 1; i < argc; i++) {
+        for (const char* opt : kArgRequired) {
+            if (std::strcmp(argv[i], opt) == 0 && i + 1 >= argc) {
+                std::fprintf(stderr, "%s requires an argument\n", opt);
+                return 1;
+            }
+        }
+        if (std::strcmp(argv[i], "--adt") == 0 && i + 3 >= argc) {
+            std::fprintf(stderr, "--adt requires <map> <x> <y>\n");
+            return 1;
+        }
+    }
+
     for (int i = 1; i < argc; i++) {
         if (std::strcmp(argv[i], "--data") == 0 && i + 1 < argc) {
             dataPath = argv[++i];